extract will return literals that are part of an expression #415

Activity

1. gitmate-bot

   added

   bug

   on Jun 7, 2016
2. asottile commented on Jun 7, 2016

   

   asottile

   on Jun 7, 2016

   ContributorAuthor

   More actions

   fwiw, xgettext also picks up the first one but not the second one -- I still think picking up the first one is bug as well :)

   $ xgettext test.py -o /dev/stdout
   # SOME DESCRIPTIVE TITLE.
   # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
   # This file is distributed under the same license as the PACKAGE package.
   # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
   #
   #, fuzzy
   msgid ""
   msgstr ""
   "Project-Id-Version: PACKAGE VERSION\n"
   "Report-Msgid-Bugs-To: \n"
   "POT-Creation-Date: 2016-06-06 18:36-0700\n"
   "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
   "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
   "Language-Team: LANGUAGE <LL@li.org>\n"
   "Language: \n"
   "MIME-Version: 1.0\n"
   "Content-Type: text/plain; charset=CHARSET\n"
   "Content-Transfer-Encoding: 8bit\n"
   
   #: test.py:1
   msgid "foo"
   msgstr ""
   
3. akx commented on Jul 15, 2016

   

   akx

   on Jul 15, 2016

   Member

   More actions

   Ungh, I think fixing this will require one of the following:

   • A dirty hack (lookahead/lookbehind in the token stream to make sure we're not in, or going to be in, an expression)
   • Rewriting the extractor to use the AST module instead of the token stream (likely slower, though probably not by an awful lot). Also, I don't think it's much of an issue, but this would make parsing (more?) Python version dependent.

   I'd honestly go with the second option.
4. akx

   added

   area/messages

   on Feb 2, 2018