avoid identical text for all links (#155)

* avoid identical text for all links

* rework things

- move logic from template to code
- use list instead of decorative characters (style tbd)
- use aria labels to distinguish identical links

* style

* fix test

* drop now not needed paragraph tags

---------

Co-authored-by: Maciej Olko <maciej.olko@gmail.com>

Author: merwok

contribute.py

@@ -22,4 +22,5 @@ def get_contrib_link(language: str, repo: str | None) -> str | None:
             and 'https://explore.transifex.com/python-doc/python-newest/'
         )
         or (repo and f'https://github.com/{repo}')
+        or 'https://devguide.python.org/documentation/translations/translating/'
     )

generate.py

@@ -81,7 +81,6 @@ def get_project_data(
         change,
         built,
         translated_name=languages_built.get(language.code, ''),
-        uses_platform=language.code in contribute.pulling_from_transifex,
         contribution_link=contribute.get_contrib_link(language.code, repo),
     )
 
@@ -95,7 +94,6 @@ class LanguageProjectData:
     change: float
     built: bool
     translated_name: str
-    uses_platform: bool
     contribution_link: str | None
 
 

src/style.css

@@ -90,6 +90,19 @@ body {
   background-color: #f5e9a8;
 }
 
+ul.links-row {
+  display: flex;
+  padding-left: 0;
+  list-style: none;
+}
+ul.links-row li:not(:first-child) {
+  padding-left: 1ch;
+}
+ul.links-row li:not(:first-child)::before {
+  content: '•';
+  margin-right: 0.5ch;
+}
+
 /* ------------------------------ Index ------------------------------------- */
 
 .progress-bar-container {

templates/index.html.jinja

@@ -12,19 +12,19 @@
             <p class="text-muted">Completion: <strong>{{ '{:.2f}%'.format(project.completion) }}</strong></p>
             <p class="text-muted">30-day progress: {{ '{:.2f}%'.format(project.change) }}</p>
 
-            <p style="text-align: center;">
+            <ul class="links-row">
               {% if project.built %}
-                <a href="https://docs.python.org/{{ project.language.code }}/3/" style="color: #1178cc;">View</a>
-                •
+              <li>
+                <a href="https://docs.python.org/{{ project.language.code }}/3/" aria-label="View {{ project.language.name }} documentation"
+                   style="color: #1178cc;">View</a>
+              </li>
               {% endif %}
-              {% if project.contribution_link %}
-                <a href="{{ project.contribution_link }}" style="color: #1178cc;">Contribute</a>
-              {% elif project.uses_platform %}
-                <a href="https://app.transifex.com/join/?o=python-doc&p=python-newest&t=opensource" style="color: #1178cc;">Contribute</a>
-              {% else %}
-                <a href="https://devguide.python.org/documentation/translations/translating/" style="color: #1178cc;">Contribute</a>
-              {% endif %}
-            </p>
+              <li>
+                <a href="{{ project.contribution_link }}" style="color: #1178cc;" aria-label="Contribute to {{ project.language.name }} translation">
+                  Contribute
+                </a>
+              </li>
+            </ul>
             <div class="progress-bar-container">
               <div class="progress-bar" style="width: {{ project.completion }}%;
                 {% if project.change %}

tests/test_contribute.py

@@ -9,9 +9,10 @@
 class testContributeLink(unittest.TestCase):
     def test_get_contrib_link(self):
         PULL_FROM_TX = 'https://explore.transifex.com/python-doc/python-newest/'
+        DEVGUIDE = 'https://devguide.python.org/documentation/translations/translating/'
 
         for code, repo, expected in (
-            ('en', None, None),
+            ('en', None, DEVGUIDE),
             ('pl', None, PULL_FROM_TX),
             ('ar', 'python/python-docs-ar', 'https://github.com/python/python-docs-ar'),
             (