Fix sed in release pipeline. #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `;` was missing between the two `s///` statements; without it it failed with an error about "unknown flag". Tested with act to get _some_ sembalance of an idea if it will work, but it's no guarantee ``` act \ --env GITHUB_REPOSITORY=python-pendulum/pendulum \ -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:rust-latest \ --artifact-server-path $PWD/.artifacts \ -W .github/workflows/release.yml \ --matrix container:off,target:aarch64 \ --container-architecture linux/amd64 ```
ashb
commented
Apr 16, 2025
| @@ -103,7 +103,7 @@ jobs: | |||
| - name: Hotswap build backend for Poetry | |||
| # Maturin doesn't support building no-extension wheels, so we swap to Poetry for that | |||
| run: | | |||
| sed -i '/^\[build-system\]/,/^\[/{s/^requires = .*/requires = ["poetry-core>=2.0.0,<3.0.0"]/ s/^build-backend = .*/build-backend = "poetry.core.masonry.api"/}' pyproject.toml | |||
| sed -i -e '/^\[build-system\]/,/^\[/{s/^requires = .*/requires = ["poetry-core>=2.0.0,<3.0.0"]/; s/^build-backend = .*/build-backend = "poetry.core.masonry.api"/}' pyproject.toml | |||
There was a problem hiding this comment.
The -e may or may have not been required, but this def worked for me in act
CodSpeed Performance ReportMerging #890 will not alter performanceComparing Summary
|
Secrus
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
;was missing between the twos///statements; without it it failedwith an error of
sed: -e expression #1, char 86: unknown option tos'`Tested with act to get some sembalance of an idea if it will work, but it's
no guarantee
Pull Request Check List