Skip to content

Commit 20e0baf

Browse files
authored
Feat: Eliminar emojis (#103)
Los emojis son elementos accesibles porquè el lector de pantalla los sabe leer. Cuando aportan información, se deben conservar, por ejemplo, una reacción a un comentario, una carita sonriente al final de una frase para expresar emoción, etc. En mi opinión, la mayoría de emojis de la página de sponsors son puramente decorativos, para que la página se vea más bonita, por eso en esta PR los he marcado como `aria-hidden="true"` También he añadido el `%` a los textos del apartado 'intereses' como pidió @dukebody
1 parent 14cc454 commit 20e0baf

File tree

1 file changed

+20
-17
lines changed

1 file changed

+20
-17
lines changed

src/pages/[lang]/sponsors.astro

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ const {
6666
{
6767
stats.items.map((stat) => (
6868
<div class="bg-white text-pycon-black p-4 rounded-lg border border-white/10 text-center">
69-
<div class="text-3xl mb-2">{stat.icon}</div>
69+
<div class="text-3xl mb-2" aria-hidden="true">
70+
{stat.icon}
71+
</div>
7072
<div class="text-2xl font-bold ">{stat.value}</div>
7173
<div class="text-sm">{stat.label}</div>
7274
</div>
@@ -96,7 +98,10 @@ const {
9698

9799
<div class="grid md:grid-cols-2 gap-6">
98100
<div class="bg-white text-pycon-black p-6 rounded-lg border border-white/10">
99-
<h3 class="text-xl font-bold mb-4">📍 {location.where}</h3>
101+
<h3 class="text-xl font-bold mb-4">
102+
<span aria-hidden="true">📍</span>
103+
{location.where}
104+
</h3>
100105
<p class="mb-4">
101106
{location.body}
102107
<strong>{location.bodyStrong}</strong>
@@ -108,7 +113,7 @@ const {
108113
</div>
109114

110115
<div class="bg-white text-pycon-black p-6 rounded-lg border border-white/10">
111-
<h3 class="text-xl font-bold mb-4">📅 {when.title}</h3>
116+
<h3 class="text-xl font-bold mb-4"><span aria-hidden="true">📅</span> {when.title}</h3>
112117
<div class="space-y-3">
113118
<p>
114119
<strong>{when.friday}: </strong>{when.fridayStrong}
@@ -146,7 +151,9 @@ const {
146151
{
147152
whySponsor.items.map((item) => (
148153
<div class="flex gap-3">
149-
<span class="text-xl">{item.icon}</span>
154+
<span class="text-xl" aria-hidden="true">
155+
{item.icon}
156+
</span>
150157
<div>
151158
<strong>{item.title}:</strong>
152159
<span class="text-sm"> {item.desc}</span>
@@ -166,12 +173,7 @@ const {
166173
<div class="bg-white text-pycon-black p-8 rounded-lg border border-white/10 mb-6">
167174
<h3 class="mb-6 font-mono">{audience.seniority}</h3>
168175

169-
<div
170-
role="img"
171-
aria-label=""
172-
aria-hidden="true"
173-
class="flex w-full h-12 rounded-lg overflow-hidden mb-3"
174-
>
176+
<div aria-label="" aria-hidden="true" class="flex w-full h-12 rounded-lg overflow-hidden mb-3">
175177
<div
176178
style="width: 38%"
177179
class="h-full min-w-[2rem] bg-pycon-yellow text-pycon-black text-xs font-bold flex items-center justify-center"
@@ -215,7 +217,9 @@ const {
215217
{
216218
audience.items.map((item) => (
217219
<div class="bg-white p-4 rounded-lg border border-white/10 text-center">
218-
<div class="text-2xl mb-1">{item.icon}</div>
220+
<div class="text-2xl mb-1" aria-hidden="true">
221+
{item.icon}
222+
</div>
219223
<div class="text-lg font-bold text-pycon-black">{item.value}</div>
220224
<div class="text-md text-gray-700">{item.label}</div>
221225
</div>
@@ -249,14 +253,11 @@ const {
249253
aria-hidden="true"
250254
/>
251255
<span aria-hidden="true" class="truncate">
252-
{interest.label}
256+
{interest.label} {interest.pc}
253257
</span>
254258
<span aria-hidden="true" class="mr-2">
255259
{interest.emoji}
256260
</span>
257-
<span class="sr-only">
258-
{interest.label} {interest.pc}
259-
</span>
260261
</div>
261262
))}
262263
</div>
@@ -481,7 +482,9 @@ const {
481482
{
482483
pythonSpainPoints.items.map((point) => (
483484
<div class="flex gap-3">
484-
<span class="text-2xl">{point.icon}</span>
485+
<span class="text-2xl" aria-hidden="true">
486+
{point.icon}
487+
</span>
485488
<div>
486489
<strong class="text-pycon-red">{point.title}</strong>
487490
<p class="text-gray-600 text-sm mt-1">{point.desc}</p>
@@ -514,7 +517,7 @@ const {
514517

515518
<!-- Social links -->
516519
<section class="text-center pb-16">
517-
<h3 class="text-xl font-bold mb-6">{socialLinks.title}</h3>
520+
<h2 class="text-xl font-bold mb-6">{socialLinks.title}</h2>
518521
<div class="flex flex-wrap justify-center gap-4">
519522
{
520523
socialLinks.items.map((link) => (

0 commit comments

Comments
 (0)