Skip to content

Consistently spill the evaluation stack when making escaping calls #128682

Open
@markshannon

Description

Currently, we spill the evaluation stack for most escaping calls, but not all.
For a few calls, notably Py_DECREF, PyStackRef_CLOSE and related calls, the stack isn't spilled.

Spilling in those cases would add a fair bit of complexity to the code generator and might produce a small slowdown, but it is worth it.

Knowing that all values are in memory and visible during escaping calls allows us to be much less conservative
when handling reference counts. We can potentially defer many, many more references as the GC is guaranteed to
be able to find all references on the stack. The free-threading build can avoid having to NULL out the stack
as will only see the valid part of the stack.

There are also benefits unrelated to performance: debuggers and other tools can reliably see values on the stack,
providing more information that just local variables. For example, having the full stack visible during sys.monitoring
INSTRUCTION events allows reversable debuggers to be implemented more simply.

Tasks

Preview Give feedback

Linked PRs

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions