Skip to content

Leftover code in sysconfig.expand_makefile_vars #128978

Open
@picnixz

Description

Bug report

Bug description:

I think there is some leftover code in sysconfig.expand_makefile_vars (90d02e5):

while True:
m = re.search(_findvar1_rx, s) or re.search(_findvar2_rx, s)
if m:
(beg, end) = m.span()
s = s[0:beg] + vars.get(m.group(1)) + s[end:]
else:
break
return s

The _findvar1_rx and _findvar2_rx variables are not declared at all (they were moved to sysconfig/__main__.py). Since the function is publicly named (but not exported nor documented), I prefer backporting the changes of #110785, namely re-use the patterns as is.

cc @FFY00

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Metadata

Assignees

Labels

3.12bugs and security fixes3.13bugs and security fixes3.14new features, bugs and security fixesstdlibPython modules in the Lib dirtype-bugAn unexpected behavior, bug, or error

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions