Dictionary max modifications threshold too low for JIT

[Fidget-Spinner]

If you just run something like import time, the globals to constants promoter fails. This seems counterproductive.

We should up the max number of dictionary modifications allowed to something in the hundreds range, or whatever a big app might suggest.

[Fidget-Spinner]

@markshannon

[brandtbucher]

Do you mind clarifying what's happening here? Do you have a reproducer?

It seems like the case you're describing would be:

• JIT some code.
• Perform a module-level import.
• JIT some code.
• Perform a module-level import.
• JIT some code.
• Perform a module-level import.
• JIT some code.
• Perform a module-level import.
• JIT some code.
• Perform a module-level import.
• JIT some code.
• Perform a module-level import.

At that point, the globals to constants promotion starts failing for code in that module. But that seems like a highly unusual code pattern to me.

[brandtbucher]

(And frankly, if that is the code pattern, we probably should stop promoting globals to constants in that module.)