Skip to content

Commit 3e489a6

Browse files
Move _what-s-new-and-news-entries to pull-request-lifecycle
1 parent ff5cf4a commit 3e489a6

File tree

2 files changed

+98
-98
lines changed

2 files changed

+98
-98
lines changed

core-developers/committing.rst

Lines changed: 1 addition & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -72,104 +72,7 @@ to enter the public source tree. Ask yourself the following questions:
7272
significant improvements, or backwards-incompatible changes), then an
7373
entry in the ``What's New in Python`` document (in ``Doc/whatsnew/``) should
7474
be added as well. Changes that affect only documentation generally do not
75-
require a ``NEWS`` entry. (See the following section for more information.)
76-
77-
.. _news-entry:
78-
.. _what-s-new-and-news-entries:
79-
80-
Updating NEWS and What's New in Python
81-
--------------------------------------
82-
83-
Changes that require NEWS entries
84-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
85-
86-
Most changes made to the codebase deserve an entry in :cpy-file:`Misc/NEWS.d`,
87-
except for the following:
88-
89-
* documentation changes
90-
* test changes
91-
* strictly internal changes with no user-visible effects
92-
* changes that already have a ``NEWS`` entry
93-
* reverts that have not yet been included in any formal release
94-
(including alpha and beta releases)
95-
96-
For the last two, note the following:
97-
98-
#. **If a change is reverted prior to release**, then the corresponding
99-
entry is simply removed. Otherwise, a new entry must be added noting
100-
that the change has been reverted (for example, when a feature is released in
101-
an alpha and then cut prior to the first beta).
102-
103-
#. **If a change is a fix (or other adjustment) to an earlier unreleased
104-
change and the original** ``NEWS`` **entry remains valid**, then no additional
105-
entry is needed.
106-
107-
Changes that require "What's New in Python" entries
108-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
109-
110-
If a change is particularly interesting for end users (for example, new features,
111-
significant improvements, or backwards-incompatible changes), add an entry in
112-
the "What's New in Python" document (in :cpy-file:`Doc/whatsnew/`)
113-
in addition to the ``NEWS`` entry.
114-
115-
In most cases, it is sufficient to reuse the wording from the ``NEWS`` entry
116-
in the "What's New in Python" entry.
117-
118-
.. note::
119-
120-
A change that needs an entry in "What's New in Python",
121-
is very likely not suitable for inclusion in a maintenance release.
122-
123-
How to add a NEWS entry
124-
^^^^^^^^^^^^^^^^^^^^^^^
125-
126-
``NEWS`` entries go into the ``Misc/NEWS.d`` directory as individual files. The
127-
``NEWS`` entry can be created by using `blurb-it <https://blurb-it.herokuapp.com/>`_,
128-
or the :pypi:`blurb` tool and its ``blurb add`` command.
129-
130-
If you are unable to use the tool, then you can create the ``NEWS`` entry file
131-
manually. The ``Misc/NEWS.d`` directory contains a sub-directory named
132-
``next``, which contains various sub-directories representing classifications
133-
for what was affected (for example, ``Misc/NEWS.d/next/Library`` for changes relating
134-
to the standard library). The file name itself should be in the format
135-
``<datetime>.gh-issue-<issue-number>.<nonce>.rst``:
136-
137-
* ``<datetime>`` is today's date joined with a hyphen (``-``) to your current
138-
local time, in the ``YYYY-MM-DD-hh-mm-ss`` format (for example, ``2017-05-27-16-46-23``).
139-
* ``<issue-number>`` is the issue number the change is for (for example, ``12345``
140-
for ``gh-issue-12345``).
141-
* ``<nonce>`` is a unique string to guarantee that the file name is
142-
unique across branches (for example, ``Yl4gI2``). It is typically six characters
143-
long, but it can be any length of letters and numbers. Its uniqueness
144-
can be satisfied by typing random characters on your keyboard.
145-
146-
As a result, a file name can look something like
147-
``Misc/NEWS.d/next/Library/2017-05-27-16-46-23.gh-issue-12345.Yl4gI2.rst``.
148-
149-
How to write a NEWS entry
150-
^^^^^^^^^^^^^^^^^^^^^^^^^
151-
152-
All ``NEWS`` entries end up being part of the changelog.
153-
The changelog contains *a lot* of entries,
154-
and its intended audience is mainly users, not core devs and contributors.
155-
Take this into consideration when wording your ``NEWS`` entry.
156-
Describe the user-visible effects of your change succinctly and accurately;
157-
avoid long technical elaborations, digressions, and do not expect or require
158-
the reader to have read the actual diff for the change.
159-
160-
The contents of a ``NEWS`` file should be valid reStructuredText. An 80 character
161-
column width should be used. There is no indentation or leading marker in the
162-
file (for example, ``-``). There is also no need to start the entry with the issue
163-
number since it is part of the file name. You can use
164-
:ref:`inline markups <rest-inline-markup>` too. Here is an example of a ``NEWS``
165-
entry::
166-
167-
Fix warning message when :func:`os.chdir` fails inside
168-
:func:`test.support.temp_cwd`. Contributed by Chris Jerdonek.
169-
170-
The inline Sphinx roles like ``:func:`` can be used help readers
171-
find more information. You can build HTML and verify that the
172-
link target is appropriate by using :ref:`make html <building-using-make>`.
75+
require a ``NEWS`` entry. (See :ref:`_what-s-new-and-news-entries`.)
17376

17477

17578
Working with Git_

getting-started/pull-request-lifecycle.rst

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,103 @@ should do to help ensure that your pull request is accepted.
237237

238238
#. Proper :ref:`documentation <documenting>` additions/changes should be included.
239239

240+
.. _news-entry:
241+
.. _what-s-new-and-news-entries:
242+
243+
Updating NEWS and What's New in Python
244+
--------------------------------------
245+
246+
Changes that require NEWS entries
247+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
248+
249+
Most changes made to the codebase deserve an entry in :cpy-file:`Misc/NEWS.d`,
250+
except for the following:
251+
252+
* documentation changes
253+
* test changes
254+
* strictly internal changes with no user-visible effects
255+
* changes that already have a ``NEWS`` entry
256+
* reverts that have not yet been included in any formal release
257+
(including alpha and beta releases)
258+
259+
For the last two, note the following:
260+
261+
#. **If a change is reverted prior to release**, then the corresponding
262+
entry is simply removed. Otherwise, a new entry must be added noting
263+
that the change has been reverted (for example, when a feature is released in
264+
an alpha and then cut prior to the first beta).
265+
266+
#. **If a change is a fix (or other adjustment) to an earlier unreleased
267+
change and the original** ``NEWS`` **entry remains valid**, then no additional
268+
entry is needed.
269+
270+
Changes that require "What's New in Python" entries
271+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
272+
273+
If a change is particularly interesting for end users (for example, new features,
274+
significant improvements, or backwards-incompatible changes), add an entry in
275+
the "What's New in Python" document (in :cpy-file:`Doc/whatsnew/`)
276+
in addition to the ``NEWS`` entry.
277+
278+
In most cases, it is sufficient to reuse the wording from the ``NEWS`` entry
279+
in the "What's New in Python" entry.
280+
281+
.. note::
282+
283+
A change that needs an entry in "What's New in Python",
284+
is very likely not suitable for inclusion in a maintenance release.
285+
286+
How to add a NEWS entry
287+
^^^^^^^^^^^^^^^^^^^^^^^
288+
289+
``NEWS`` entries go into the ``Misc/NEWS.d`` directory as individual files. The
290+
``NEWS`` entry can be created by using `blurb-it <https://blurb-it.herokuapp.com/>`_,
291+
or the :pypi:`blurb` tool and its ``blurb add`` command.
292+
293+
If you are unable to use the tool, then you can create the ``NEWS`` entry file
294+
manually. The ``Misc/NEWS.d`` directory contains a sub-directory named
295+
``next``, which contains various sub-directories representing classifications
296+
for what was affected (for example, ``Misc/NEWS.d/next/Library`` for changes relating
297+
to the standard library). The file name itself should be in the format
298+
``<datetime>.gh-issue-<issue-number>.<nonce>.rst``:
299+
300+
* ``<datetime>`` is today's date joined with a hyphen (``-``) to your current
301+
local time, in the ``YYYY-MM-DD-hh-mm-ss`` format (for example, ``2017-05-27-16-46-23``).
302+
* ``<issue-number>`` is the issue number the change is for (for example, ``12345``
303+
for ``gh-issue-12345``).
304+
* ``<nonce>`` is a unique string to guarantee that the file name is
305+
unique across branches (for example, ``Yl4gI2``). It is typically six characters
306+
long, but it can be any length of letters and numbers. Its uniqueness
307+
can be satisfied by typing random characters on your keyboard.
308+
309+
As a result, a file name can look something like
310+
``Misc/NEWS.d/next/Library/2017-05-27-16-46-23.gh-issue-12345.Yl4gI2.rst``.
311+
312+
How to write a NEWS entry
313+
^^^^^^^^^^^^^^^^^^^^^^^^^
314+
315+
All ``NEWS`` entries end up being part of the changelog.
316+
The changelog contains *a lot* of entries,
317+
and its intended audience is mainly users, not core devs and contributors.
318+
Take this into consideration when wording your ``NEWS`` entry.
319+
Describe the user-visible effects of your change succinctly and accurately;
320+
avoid long technical elaborations, digressions, and do not expect or require
321+
the reader to have read the actual diff for the change.
322+
323+
The contents of a ``NEWS`` file should be valid reStructuredText. An 80 character
324+
column width should be used. There is no indentation or leading marker in the
325+
file (for example, ``-``). There is also no need to start the entry with the issue
326+
number since it is part of the file name. You can use
327+
:ref:`inline markups <rest-inline-markup>` too. Here is an example of a ``NEWS``
328+
entry::
329+
330+
Fix warning message when :func:`os.chdir` fails inside
331+
:func:`test.support.temp_cwd`. Contributed by Chris Jerdonek.
332+
333+
The inline Sphinx roles like ``:func:`` can be used help readers
334+
find more information. You can build HTML and verify that the
335+
link target is appropriate by using :ref:`make html <building-using-make>`.
336+
240337

241338
Copyrights
242339
==========

0 commit comments

Comments
 (0)