Fix conditional_type_map to not broaden the type (#10739) #10912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: websockets (https://github.com/aaugustin/websockets.git)
+ src/websockets/legacy/protocol.py:537: error: Redundant cast to "Iterable[Union[str, bytes]]"
spark (https://github.com/apache/spark.git)
+ python/pyspark/pandas/frame.py:6580: error: Unsupported operand types for < ("Tuple[Any, ...]" and "int")
+ python/pyspark/pandas/frame.py:6580: note: Left operand is of type "Union[int, Union[Any, Tuple[Any, ...]]]"
+ python/pyspark/pandas/frame.py:6588: error: No overload variant of "__add__" of "tuple" matches argument type "int"
+ python/pyspark/pandas/frame.py:6588: note: Possible overload variants:
+ python/pyspark/pandas/frame.py:6588: note: def __add__(self, Tuple[Any, ...]) -> Tuple[Any, ...]
+ python/pyspark/pandas/frame.py:6588: note: def [_T] __add__(self, Tuple[_T, ...]) -> Tuple[Union[Any, _T], ...]
+ python/pyspark/pandas/frame.py:6588: note: Left operand is of type "Union[int, Union[Any, Tuple[Any, ...]]]"
|
|
@ahuhn Did you close this only due to lack of uptake? |
|
@ikonst I was just cleaning out my old PRs that I hadn't come back to in a while. Happy to re-open it if people are interested in the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10739
Previously, if you used an isinstance check that is more broad than the current type, it would broaden the current type to the type of the isinstance.
After this change, an isinstance check can only narrow the type, not expand it.
Test Plan
I added a test
testIsInstanceWithNonSubsetOverlapand ran it locally, both the individual test and with./runtests.py. My new test failed before my change and succeeded after my change.Then I tried it out on a codebase and I saw a few new failures. I added regression tests to maintain the old behavior
testIsInstanceWithTypeVartestIsInstanceWithTypeVarAndSubclassThe change I made to pass those new regression tests was to switch from
meet_typestonarrow_declared_type.