-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to allow more flexible variable redefinition #18727
base: master
Are you sure you want to change the base?
Conversation
I fixed issues related to the three examples mentioned above by @cdce8p and @A5rocks. It took me a while since I've been traveling.
I didn't change this to silently infer |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This lets us see the impact on mypy primer.
Temporarily enabled |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There are still some false positives in the mypy_primer output that I want to fix before merging, but I won't attempt to fix every single issue in this PR, since the new behavior is behind a flag. |
Sure, there is no point in turning this into a mega-PR. Let me know if/when you want me to review this PR again. |
Btw if you want a clean mypy_primer diff on the local partial types front, you can try something like:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Since the PR also changes how |
This reverts commit 24afddd.
@ilevkivskyi I'm not planning any further changes before merging. I'd like to merge this in a few days. It would be great if you can review my recent changes. |
…l-types" This reverts commit 69fd839.
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thanks!
Infer union types for simple variables from multiple assignments, if the variable isn't annotated. The feature is enabled via
--allow-redefinition-new
.--local-partial-types
must also be enabled.This is still experimental and has known issues, so it's not documented anywhere. It works well enough that it can be used for non-trivial experimentation, however.
Closes #6233. Closes #6232. Closes #18568. Fixes #18619.
In this example, the type of
x
is inferred asint | str
when using the new behavior:Here is a summary of how it works:
None
values are no longer special, and we don't use partial None if the feature is enabled for simple variables.self.x
) continue to work as in the past. Attribute types can't be widened, since they are externally visible and widening could cause confusion, but this is something we might relax in the future. Globals can be widened, however. This seems necessary for consistency.x = 0
outside loop andx = [x]
within the loop body).There are some other known bugs and limitations:
nonlocal
and some other features. We don't have good test coverage for deferrals, mypy daemon, and disabling strict optional.In self check the feature generates 6 additional errors, which all seem correct -- we infer more precise types, which will generate additional errors due to invariant containers and fixing false negatives.
When type checking the largest internal codebase at Dropbox, this generated about 700 new errors, the vast majority of which seemed legitimate. Mostly they were due to inferring more precise types for variables that used to have
Any
types. I used a recent but not the latest version of the feature to type check the internal codebase.