Add IPv6 support to socketserver.BaseServer

[DiegoBaldassarMilleuno]

The constructors for the *Server classes in socketserver.pyi should accept as the value for the server_address parameter a 4-tuple specifying an IPv6 socket.

The typing is currently tuple[str, int] (which is the type for AF_INET sockets), but the constructors can also take tuple[str, int, int, int] (for AF_INET6); as such, it makes sense to update the type to tuple[str, int] | tuple[str, int, int, int], matching the sockaddr (last) field from the return value of socket.getaddrinfo().

The only usage of server_address in the file is as an argument to socket.socket.bind(), so it could possibly make sense to change the type to _socket._Address | bytes.

Definitions:

• server_address
• socket.getaddrinfo()
• socket.socket.bind()
• _Address

[srittau]

Any PRs to improve the situation are welcome!

[aminalaee]

I tried to look into this, it seems like BaseServer supports a dynamic tuple now, not sure why the issue references are from a fork:

typeshed/stdlib/socketserver.pyi

Line 41 in 2c05c02

server_address: _Address

But for TCPServer it only accepts (host, port) which is according to CPython implementation only supporting AF_INET socket family:
https://github.com/python/cpython/blob/94c95d42a3b74729ee775f583fb7951f05d16c77/Lib/socketserver.py#L440
and this doesn't include AF_INET6 implementaion. So not sure what should be changed here.

Pinging @JelleZijlstra since he made recent changes.

[DiegoBaldassarMilleuno]

See this from CPython:
https://github.com/python/cpython/blob/94c95d42a3b74729ee775f583fb7951f05d16c77/Lib/http/server.py#L1265
It seems that changing the value of address_family is intended usage (the docstring for TCPServer confirms this). Also the module docstring in socketserver.py seems to imply that all the classes defined there support multiple address families.

I can indeed confirm that running: python -m http.server --bind ::1 works correctly.

Also, sorry for inadvertently linking to the fork, I blame the new GitHub UI.