add tests for correct usage of override with an overload

Author: carljm

conformance/results/mypy/overloads_invalid.toml

@@ -5,6 +5,7 @@ Does not allow an overload with no implementation in an abstract base class.
 """
 errors_diff = """
 Line 49: Unexpected errors ['overloads_invalid.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]']
+Line 199: Unexpected errors ['overloads_invalid.py:199: error: Signature of "good_override" incompatible with supertype "Base"  [override]']
 """
 output = """
 overloads_invalid.py:14: error: Single overload definition, multiple required  [misc]
@@ -15,15 +16,24 @@ overloads_invalid.py:78: error: Overload does not consistently use the "@staticm
 overloads_invalid.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 1  [misc]
 overloads_invalid.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 2  [misc]
 overloads_invalid.py:91: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
-overloads_invalid.py:127: error: @final should be applied only to overload implementation  [misc]
-overloads_invalid.py:139: error: @final should be applied only to overload implementation  [misc]
-overloads_invalid.py:155: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
-overloads_invalid.py:155: error: Signature of "final_method" incompatible with supertype "Base"  [override]
-overloads_invalid.py:155: note:      Superclass:
-overloads_invalid.py:155: note:          @overload
-overloads_invalid.py:155: note:          def final_method(self, x: int) -> int
-overloads_invalid.py:155: note:          @overload
-overloads_invalid.py:155: note:          def final_method(self, x: str) -> str
-overloads_invalid.py:155: note:      Subclass:
-overloads_invalid.py:155: note:          def final_method(self, x: int | str) -> int | str
+overloads_invalid.py:133: error: @final should be applied only to overload implementation  [misc]
+overloads_invalid.py:148: error: @final should be applied only to overload implementation  [misc]
+overloads_invalid.py:173: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
+overloads_invalid.py:173: error: Signature of "final_method" incompatible with supertype "Base"  [override]
+overloads_invalid.py:173: note:      Superclass:
+overloads_invalid.py:173: note:          @overload
+overloads_invalid.py:173: note:          def final_method(self, x: int) -> int
+overloads_invalid.py:173: note:          @overload
+overloads_invalid.py:173: note:          def final_method(self, x: str) -> str
+overloads_invalid.py:173: note:      Subclass:
+overloads_invalid.py:173: note:          def final_method(self, x: int | str) -> int | str
+overloads_invalid.py:180: error: Method "bad_override" is marked as an override, but no base method was found with this name  [misc]
+overloads_invalid.py:199: error: Signature of "good_override" incompatible with supertype "Base"  [override]
+overloads_invalid.py:199: note:      Superclass:
+overloads_invalid.py:199: note:          def good_override(self, x: int | str) -> int | str
+overloads_invalid.py:199: note:      Subclass:
+overloads_invalid.py:199: note:          @overload
+overloads_invalid.py:199: note:          def good_override(self, x: int) -> int
+overloads_invalid.py:199: note:          @overload
+overloads_invalid.py:199: note:          def good_override(self, x: str) -> str
 """

conformance/results/pyre/overloads_invalid.toml

@@ -2,13 +2,14 @@ conformant = "Partial"
 conformance_automated = "Fail"
 notes = """
 Does not allow an overload with no implementation in a Protocol or an abstract base class.
-Expects @final on all overloads and implementation, instead of implementation only.
+Expects @final/@override on all overloads and implementation, instead of implementation only.
 """
 errors_diff = """
-Lines 139, 141: Expected error (tag 'invalid_final_2')
+Lines 148, 150: Expected error (tag 'invalid_final_2')
 Line 40: Unexpected errors ['overloads_invalid.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.']
 Line 51: Unexpected errors ['overloads_invalid.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.']
-Line 124: Unexpected errors ['overloads_invalid.py:124:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 128: Unexpected errors ['overloads_invalid.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 208: Unexpected errors ['overloads_invalid.py:208:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
 """
 output = """
 overloads_invalid.py:15:0 Incompatible overload [43]: At least two overload signatures must be present.
@@ -21,7 +22,10 @@ overloads_invalid.py:85:4 Incompatible overload [43]: The implementation of `C.f
 overloads_invalid.py:88:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 overloads_invalid.py:97:4 Incompatible overload [43]: The implementation of `C.func6` does not accept all possible arguments of overload defined on line `97`.
 overloads_invalid.py:97:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_invalid.py:124:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_invalid.py:133:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_invalid.py:155:4 Invalid override [40]: `overloads_invalid.Child.final_method` cannot override final method defined in `Base`.
+overloads_invalid.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:139:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:173:4 Invalid override [40]: `overloads_invalid.Child.final_method` cannot override final method defined in `Base`.
+overloads_invalid.py:189:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:189:4 Invalid override [40]: `overloads_invalid.Child.bad_override` is decorated with @override, but no method of the same name exists in superclasses of `Child`.
+overloads_invalid.py:208:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 """

conformance/results/pyright/overloads_invalid.toml

@@ -4,7 +4,7 @@ Allows @final on all overloads and implementation; should be implementation-only
 """
 conformance_automated = "Fail"
 errors_diff = """
-Lines 139, 141: Expected error (tag 'invalid_final_2')
+Lines 148, 150: Expected error (tag 'invalid_final_2')
 """
 output = """
 overloads_invalid.py:15:5 - error: "func1" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
@@ -25,10 +25,11 @@ overloads_invalid.py:88:9 - error: Overloaded implementation is not consistent w
     Extra parameter "x" (reportInconsistentOverload)
 overloads_invalid.py:93:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
 overloads_invalid.py:97:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
-overloads_invalid.py:129:9 - error: Overload for "invalid_final" is marked @final but implementation is not (reportInconsistentOverload)
-overloads_invalid.py:155:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
-overloads_invalid.py:155:9 - error: Method "final_method" overrides class "Base" in an incompatible manner
+overloads_invalid.py:135:9 - error: Overload for "invalid_final" is marked @final but implementation is not (reportInconsistentOverload)
+overloads_invalid.py:173:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
+overloads_invalid.py:173:9 - error: Method "final_method" overrides class "Base" in an incompatible manner
   Return type mismatch: base method returns type "int", override returns type "int | str"
     Type "int | str" is not assignable to type "int"
       "str" is not assignable to "int" (reportIncompatibleMethodOverride)
+overloads_invalid.py:189:9 - error: Method "bad_override" is marked as override, but no base method of same name is present (reportGeneralTypeIssues)
 """