check_for_collision: Trigger spritelist init if needed (#2662)

Author: einarf

arcade/sprite_list/collision.py

@@ -154,7 +154,7 @@ def _get_nearby_sprites(
     # Run the transform shader emitting sprites close to the configured position and size.
     # This runs in a query so we can measure the number of sprites emitted.
     with ctx.collision_query:
-        sprite_list._geometry.transform(  # type: ignore
+        sprite_list.geometry.transform(  # type: ignore
             ctx.collision_detection_program,
             buffer,
             vertices=sprite_count,

arcade/sprite_list/sprite_list.py

@@ -521,10 +521,10 @@ def geometry(self) -> Geometry:
             in float in_texture;
             in vec4 in_color;
         """
-        if not self._geometry:
-            raise ValueError("SpriteList is not initialized.")
+        if not self._initialized:
+            self.initialize()
 
-        return self._geometry
+        return self._geometry  # type: ignore
 
     @property
     def buffer_positions(self) -> Buffer:

tests/unit/sprite/test_sprite_collision.py

@@ -311,3 +311,15 @@ def test_get_sprites_in_rect(use_spatial_hash):
     assert set(arcade.get_sprites_in_rect(arcade.LRBT(100, 200, 100, 200), sp)) == set()
     assert set(arcade.get_sprites_in_rect(arcade.LRBT(-100, 0, -100, 0), sp)) == {b, d}
     assert set(arcade.get_sprites_in_rect(arcade.LRBT(100, 0, 100, 0), sp)) == {a, c}
+
+
+def test_cpu_collision_with_lazy_list(window):
+    """
+    Do GPU collision check with lazy list.
+    This ensures that check_for_collision_with_list() will trigger
+    a spritelist initialization if his is not done yet.
+    """
+    sprite = arcade.SpriteSolidColor(50, 50, color=arcade.csscolor.RED)
+    spritelist = arcade.SpriteList(lazy=True)
+    spritelist.append(arcade.SpriteSolidColor(50, 50, color=arcade.csscolor.RED))
+    arcade.check_for_collision_with_list(sprite, spritelist, method=2)