Skip to content

Commit fa50b44

Browse files
committed
merge development, fix some naming
1 parent b316bbf commit fa50b44

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

arcade/gui/widgets/slider.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ def _apply_step(self, value: float):
114114

115115
return value
116116

117-
def _change_value(self, value: float):
118-
# TODO changing the value itself should trigger this event
119-
# current problem is, that the property does not pass the old value to change listeners
117+
def _set_value(self, value: float):
118+
# TODO changing the value itself should trigger `on_change` event
119+
# current problem is, that the property does not pass the old value to listeners
120120
if value < self.min_value:
121121
value = self.min_value
122122
elif value > self.max_value:
@@ -145,7 +145,7 @@ def norm_value(self):
145145
def norm_value(self, value):
146146
"""Normalized value between 0.0 and 1.0"""
147147
new_value = min(value * (self.max_value - self.min_value) + self.min_value, self.max_value)
148-
self._change_value(new_value)
148+
self._set_value(new_value)
149149

150150
@property
151151
def _thumb_x(self):

0 commit comments

Comments
 (0)