Skip to content

Commit ec1dfdd

Browse files
committed
Fixes #184 add missing form field to petition/template edit UI to set newsletter text
1 parent 1352858 commit ec1dfdd

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

pytition/petition/forms.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ class SocialNetworkForm(forms.Form):
127127
class NewsletterForm(forms.Form):
128128
### Newsletter settings of Petition ###
129129
has_newsletter = SwitchField(required=False, label=_("Does this petition have a newsletter?"))
130-
newsletter_subscribe_http_data = forms.CharField(required=False)
130+
newsletter_text = forms.CharField(required=False)
131+
newsletter_subscribe_http_data = forms.CharField(max_length=1000, required=False)
131132
newsletter_subscribe_http_mailfield = forms.CharField(max_length=100,required=False)
132133
newsletter_subscribe_http_url = forms.CharField(max_length=1000, required=False)
133134
newsletter_subscribe_mail_subject = forms.CharField(max_length=1000, required=False)

pytition/petition/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,7 @@ def edit_template(request, template_id):
579579
submitted_ctx['newsletter_form_submitted'] = True
580580
if newsletter_form.is_valid():
581581
template.has_newsletter = newsletter_form.cleaned_data['has_newsletter']
582+
template.newsletter_text = newsletter_form.cleaned_data['newsletter_text']
582583
template.newsletter_subscribe_http_data = newsletter_form.cleaned_data['newsletter_subscribe_http_data']
583584
template.newsletter_subscribe_http_mailfield = newsletter_form.cleaned_data['newsletter_subscribe_http_mailfield']
584585
template.newsletter_subscribe_http_url = newsletter_form.cleaned_data['newsletter_subscribe_http_url']
@@ -1145,6 +1146,7 @@ def edit_petition(request, petition_id):
11451146
newsletter_form = NewsletterForm(request.POST)
11461147
if newsletter_form.is_valid():
11471148
petition.has_newsletter = newsletter_form.cleaned_data['has_newsletter']
1149+
petition.newsletter_text = newsletter_form.cleaned_data['newsletter_text']
11481150
petition.newsletter_subscribe_http_data = newsletter_form.cleaned_data['newsletter_subscribe_http_data']
11491151
petition.newsletter_subscribe_http_mailfield = newsletter_form.cleaned_data['newsletter_subscribe_http_mailfield']
11501152
petition.newsletter_subscribe_http_url = newsletter_form.cleaned_data['newsletter_subscribe_http_url']

0 commit comments

Comments
 (0)