Skip to content

Commit 304f5e2

Browse files
Balandatfacebook-github-bot
authored andcommitted
Remove unnecessary cholesky_jitter call (#929)
Summary: I don't think this is doing anything; it seems to be a nullop? Pull Request resolved: #929 Reviewed By: wjmaddox Differential Revision: D30729615 Pulled By: Balandat fbshipit-source-id: 0df4694c97a526b9b09a0a67807b1dd6c19f56f2
1 parent 36186ea commit 304f5e2

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

botorch/models/multitask.py

+9-10
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
from gpytorch.priors.prior import Prior
6464
from gpytorch.priors.smoothed_box_prior import SmoothedBoxPrior
6565
from gpytorch.priors.torch_priors import GammaPrior
66-
from gpytorch.settings import cholesky_jitter, detach_test_caches
66+
from gpytorch.settings import detach_test_caches
6767
from gpytorch.utils.errors import CachingError
6868
from gpytorch.utils.memoize import cached, pop_from_cache
6969
from torch import Tensor
@@ -571,15 +571,14 @@ def posterior(
571571

572572
# now update root so that \tilde{R}\tilde{R}' \approx K_{(x,xt), (x,xt)}
573573
# cloning preserves the gradient history
574-
with cholesky_jitter(cholesky_jitter.value(X.dtype)):
575-
updated_lazy_tensor = data_data_covar.cat_rows(
576-
cross_mat=test_data_covar.clone(),
577-
new_mat=test_test_covar,
578-
method="diagonalization",
579-
)
580-
updated_root = updated_lazy_tensor.root_decomposition().root
581-
# occasionally, there's device errors so enforce this comes out right
582-
updated_root = updated_root.to(data_data_covar.device)
574+
updated_lazy_tensor = data_data_covar.cat_rows(
575+
cross_mat=test_data_covar.clone(),
576+
new_mat=test_test_covar,
577+
method="diagonalization",
578+
)
579+
updated_root = updated_lazy_tensor.root_decomposition().root
580+
# occasionally, there's device errors so enforce this comes out right
581+
updated_root = updated_root.to(data_data_covar.device)
583582

584583
# build a root decomposition of the joint train/test covariance matrix
585584
# construct (\tilde{R} \otimes M)(\tilde{R} \otimes M)' \approx

0 commit comments

Comments
 (0)