Skip to content

Erroneous Conda Windows MKL dependency #126279

Open
pytorch/builder
#1830
@baszalmstra

Description

@baszalmstra

pytorch/setup.py

Line 1112 in a0aaf56

'mkl>=2021.1.1,<=2021.4.0; platform_system == "Windows"',

This line adds a dependency to the python package on mkl >=2021.1.1,<=2021.4.0 on windows. However, the built conda packages do not align with this requirement.

For instance take the conda package win-64_pytorch-2.3.0-py3.12_cuda11.8_cudnn8_0:

The PKG_INFO inside the package lists:

Requires-Dist: mkl<=2021.4.0,>=2021.1.1; platform_system == "Windows"

However the index.json has:

  "depends": [
    ...
    "mkl 2023.1.*",
    ...
  ],

Running pip-check will fail.

However, the conda package win-64_pytorch-2.3.0-py3.9_cuda11.8_cudnn8_0 (note the py3.9) does specify:

  "depends": [
    ...
    "mkl 2021.4.*",
    ...
  ],

I think its because of these lines in the meta.yaml:

https://github.com/pytorch/builder/blob/a4b440ec0f687c84d089310d68ae3345d6eca7fc/conda/pytorch-nightly/meta.yaml#L26-27

Regardless, I think this dependency should depend on the BLAS implementation chosen, if BLAS is not set to mkl I think this dependency shouldn't be there in the first place.

cc @seemethere @malfet @osalpekar @atalman @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Metadata

Metadata

Assignees

Labels

module: binariesAnything related to official binaries that we release to usersmodule: intelSpecific to x86 architecturemodule: mklRelated to our MKL supportmodule: windowsWindows support for PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions