Skip to content

Commit 4b2c134

Browse files
authored
Run integration tests after prod deployment (#487)
Run integration tests after prod deployment and skip other post-deployment tests that manipulating the clusters ### Testing https://github.com/pytorch/ci-infra/actions/runs/24802393183
1 parent 838fe0d commit 4b2c134

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

.github/workflows/_osdc-deploy.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,21 @@ on:
1717
required: false
1818
type: boolean
1919
default: true
20+
run_smoke:
21+
description: "Run smoke tests after deploy"
22+
required: false
23+
type: boolean
24+
default: true
2025
run_integration:
2126
description: "Run integration tests after deploy (requires CANARY_GITHUB_TOKEN)"
2227
required: false
2328
type: boolean
2429
default: true
30+
run_compactor:
31+
description: "Run compactor e2e tests after deploy"
32+
required: false
33+
type: boolean
34+
default: true
2535
skip_lint_test:
2636
description: "Skip `just lint` and `just test` pre-flight checks (firefighting only)"
2737
required: false
@@ -91,6 +101,7 @@ jobs:
91101
smoke:
92102
name: Smoke tests
93103
needs: deploy
104+
if: ${{ inputs.run_smoke }}
94105
runs-on: ubuntu-latest
95106
environment: ${{ inputs.environment }}
96107
timeout-minutes: 30
@@ -125,6 +136,7 @@ jobs:
125136
compactor:
126137
name: Compactor e2e tests
127138
needs: deploy
139+
if: ${{ inputs.run_compactor }}
128140
runs-on: ubuntu-latest
129141
environment: ${{ inputs.environment }}
130142
timeout-minutes: 30

.github/workflows/osdc-deploy-prod.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ jobs:
3434
environment: osdc-production
3535
taint_nodes: ${{ inputs.taint_nodes }}
3636
skip_lint_test: ${{ inputs.skip_lint_test }}
37-
# Integration tests target pytorch-canary via CANARY_GITHUB_TOKEN —
38-
# they don't belong in a prod deploy. Always skip.
39-
run_integration: false
37+
run_smoke: false
38+
run_compactor: false
4039
secrets:
4140
META_AWS_ACC_ID: ${{ secrets.META_AWS_ACC_ID }}
4241
META_AWS_DEPLOY_ROLE: ${{ secrets.META_AWS_DEPLOY_PROD_ROLE }}
42+
CANARY_GITHUB_TOKEN: ${{ secrets.CANARY_GITHUB_TOKEN }}

0 commit comments

Comments
 (0)