Skip to content

Commit 553bd25

Browse files
authored
Add conda env for upload and extend timeout for S3 to reduce flakiness (#698) (#699)
Summary: ### Changes - Fix conda environment for conda upload - Extend timeout from 3 seconds to 10 seconds for S3 Lister to reduce recent flakiness of the test Pull Request resolved: #698 Reviewed By: NivekT Differential Revision: D38215518 Pulled By: ejguan fbshipit-source-id: cf0cd5d3979fe2b5e86e0634b257979f93f79894
1 parent a5808dc commit 553bd25

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/_build_test_upload.yml

+3
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,9 @@ jobs:
398398
CONDA_NIGHTLY_PYTORCHBOT_TOKEN: ${{ secrets.CONDA_NIGHTLY_PYTORCHBOT_TOKEN }}
399399
CONDA_TEST_PYTORCHBOT_TOKEN: ${{ secrets.CONDA_TEST_PYTORCHBOT_TOKEN }}
400400
run: |
401+
conda create -y --name conda_upload_env
402+
conda activate conda_upload_env
403+
401404
conda install -yq anaconda-client
402405
conda install -c conda-forge -yq jq
403406

test/test_remote_io.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def test_s3_io_iterdatapipe(self):
284284
"s3://aft-vbi-pds/bin-images/111",
285285
"s3://aft-vbi-pds/bin-images/222",
286286
]
287-
s3_lister_dp = S3FileLister(IterableWrapper(file_urls), region="us-east-1")
287+
s3_lister_dp = S3FileLister(IterableWrapper(file_urls), request_timeout_ms=10000, region="us-east-1")
288288
self.assertEqual(sum(1 for _ in s3_lister_dp), 2212, f"{input} failed")
289289

290290
# S3FileLister: incorrect inputs

0 commit comments

Comments
 (0)