Skip to content

pip install with BUILD_S3=TRUE broken #1451

New issue
New issue
Open
#1460
Open
pip install with BUILD_S3=TRUE broken#1451
#1460
Assignees
ramanishsingh
@h-vetinari

Description

@h-vetinari
h-vetinari
opened on Feb 24, 2025

🐛 Describe the bug

In conda-forge, we're building torchdata using python -m pip install (after setting some environment variables like USE_SYSTEM_LIBS). However, c64801f (CC @andrewkho) removed the root CMakeLists.txt, which now trivially fails the cmake build for the python extension

data/tools/setup_helpers/extension.py

Lines 125 to 126 in d155220

subprocess.check_call(["cmake", str(_ROOT_DIR)] + cmake_args, cwd=self.build_temp)
subprocess.check_call(["cmake", "--build", "."] + build_args, cwd=self.build_temp)

when using

data/tools/setup_helpers/extension.py

Lines 57 to 58 in d155220

if _BUILD_S3:
return [Pybind11Extension(name="torchdata._torchdata", sources=[])]

Given that that commit comprehensively removed torchdata/csrc etc. the fact that the install breaks with BUILD_S3=TRUE is probably an oversight.

In fact, probably a lot of that helper module can be cleaned up, since (aside from the CMake call to nowhere) none of the following variables are being used anywhere anymore

data/tools/setup_helpers/extension.py

Lines 41 to 44 in d155220

_BUILD_S3 = _get_build("BUILD_S3", False)
_USE_SYSTEM_AWS_SDK_CPP = _get_build("USE_SYSTEM_AWS_SDK_CPP", False)
_USE_SYSTEM_PYBIND11 = _get_build("USE_SYSTEM_PYBIND11", False)
_USE_SYSTEM_LIBS = _get_build("USE_SYSTEM_LIBS", False)

Versions

Starting from 0.10.1

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions