Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Commit cdc8b4e

Browse files
Kiuk Chungfacebook-github-bot
authored andcommitted
Make examples/Dockerfile pip install classy-vision from pypi
Summary: no need for the ssh key trick anymore since classy is now in pypi. Reviewed By: vreis Differential Revision: D18820153 fbshipit-source-id: 14a9ff76e5f7b69ef50d80c459f0dd041daee9db
1 parent 676a997 commit cdc8b4e

2 files changed

Lines changed: 5 additions & 14 deletions

File tree

CHANGELOG

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# CHANGELOG
22

3-
## 0.1.0-rc (December 06, 2019)
3+
## 0.1.0rc1 (December 06, 2019)
44

55
### PyTorch Elastic
66

7-
* Release torchelastic v0.1.0-rc (experimental)
7+
* First release torchelastic v0.1.0rc1 (experimental)

examples/Dockerfile

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
1-
ARG BASE_IMAGE=pytorch/elastic:0.1.0-rc
1+
ARG BASE_IMAGE=pytorch/elastic:0.1.0rc1
22
FROM $BASE_IMAGE
33

44
ARG WITH_CLASSY_VISION=1
55

6-
# install utilities
6+
# install utilities and dependencies
77
RUN pip install awscli --upgrade
88

9-
# TODO (after classy vision open sources)
10-
# 1. remove ssh_private_key hack when classy is open sourced
11-
ARG GITHUB_SSH_KEY
12-
139
RUN if [ "$WITH_CLASSY_VISION" = "1" ]; then \
14-
apt-get -yq update && apt-get -yqq install ssh && \
15-
mkdir /root/.ssh/ && \
16-
echo "${GITHUB_SSH_KEY}" > /root/.ssh/id_rsa && chmod 600 /root/.ssh/id_rsa && \
17-
ssh-keyscan github.com > /root/.ssh/known_hosts && \
18-
pip install git+ssh://git@github.com/facebookresearch/ClassyVision.git && \
19-
rm -rf /root/.ssh ; \
10+
pip install classy-vision
2011
else \
2112
echo "building without ClassyVision" ; \
2213
fi

0 commit comments

Comments
 (0)