Skip to content

Commit

Permalink
Don't repeat default for CMAKE_CXX_FLAGS_DEBUG
Browse files Browse the repository at this point in the history
Debug build type already has defaults, and the flags we set are likely to be those defaults on Unix-like platforms. Why break Windows compatibility?

ghstack-source-id: cb5834ba1b2c6196ef79af8d658077ff0c59fee4
ghstack-comment-id: 2599288517
Pull Request resolved: #7743
  • Loading branch information
swolchok committed Jan 17, 2025
1 parent a7b77d8 commit 53613ab
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ else()
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -O2")
endif()

set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g")

option(EXECUTORCH_BUILD_ANDROID_JNI "Build Android JNI" OFF)

option(EXECUTORCH_BUILD_ARM_BAREMETAL
Expand Down

0 comments on commit 53613ab

Please sign in to comment.