Skip to content

[executorch] Remove obsolete VGF slice xfail - #22083

Open
JacobSzwejbka wants to merge 1 commit into
mainfrom
remove-obsolete-vgf-slice-xfail
Open

[executorch] Remove obsolete VGF slice xfail#22083
JacobSzwejbka wants to merge 1 commit into
mainfrom
remove-obsolete-vgf-slice-xfail

Conversation

@JacobSzwejbka

@JacobSzwejbka JacobSzwejbka commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The VGF converter 0.10 upgrade makes the arange_fp32_2d_step4 slice case pass. Remove its stale strict xfail so the successful result is not reported as an XPASS failure.

Test plan: buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:slice -- --exact "fbcode//executorch/backends/arm/test:slice - test_slice.py::test_slice_tensor_vgf_no_quant_step[arange_fp32_2d_step4]"

Local OSS test was not run because pytest is not installed in this checkout environment.

This PR was authored with Codex.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22083

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unclassified Failure

As of commit a208817 with merge base 2287a8b (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 24, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo

zingo commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi this seem to still fail here in the github runner could it be another test, or maybe I missed something

trunk / test-arm-backend-vkml (test_pytest_ops_vkml) / linux-job (push)

FAILED backends/arm/test/ops/test_slice.py::test_slice_tensor_vgf_no_quant_step[arange_fp32_2d_step4] - AssertionError: Output 0 does not match reference output.
	Given atol: 0.001, rtol: 0.001.
	Output tensor shape: torch.Size([4, 3]), dtype: torch.float32
	Difference: max: 0.0, abs: 7.0, mean abs error: 1.6666666666666667.
	-- Model vs. Reference --
	 Numel: 12, 12
	Median: 16.0, 19.0
	  Mean: 18.333333333333332, 20.0
	   Max: 39.0, 39.0
	   Min: 1.0, 1.0
= 1 failed, 3781 passed, 45 skipped, 23 xfailed, 7 xpassed, 15152 warnings, 2 rerun in 4086.70s (1:08:06) =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants