Skip to content

Commit f9079b1

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Remove using namespace from header in glow/glow/include/glow/Base/SliceRange.h +1
Reviewed By: palmje Differential Revision: D56222659 fbshipit-source-id: 73a288714abce5677a57d415ea29ebd245ba5ddf
1 parent bc628fb commit f9079b1

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Diff for: include/glow/Base/SliceRange.h

-5
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@
2424
#include <unordered_set>
2525
#include <vector>
2626

27-
using namespace glow;
28-
using llvm::cast;
29-
using llvm::dyn_cast;
30-
using llvm::isa;
31-
3227
namespace glow {
3328

3429
/// Dimension range representing a contiguous [start, stop) index interval with

Diff for: tests/unittests/NodeSplittingTest.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,18 @@ TEST(TestSplitNodeOption, CheckLLVMStyleRTTI) {
4949
SplitNodeOption::SplitNodeKind::SplitNodeByChunkWeights);
5050
std::vector<SplitNodeOption *> orthogonalOpts = {&opt1, &opt2, &opt3, &opt4};
5151
for (auto opt : orthogonalOpts) {
52-
EXPECT_NE(nullptr, dyn_cast<SplitNodeOptionOrthogonal>(opt));
53-
EXPECT_EQ(nullptr, dyn_cast<SplitNodeBySliceRanges>(opt));
52+
EXPECT_NE(nullptr, llvm::dyn_cast<SplitNodeOptionOrthogonal>(opt));
53+
EXPECT_EQ(nullptr, llvm::dyn_cast<SplitNodeBySliceRanges>(opt));
5454
}
5555
// Check non-orthogonal options.
5656
std::vector<SliceRange> sliceRanges = {SliceRange({{0, 1}})};
5757
auto opt5 = SplitNodeBySliceRanges(sliceRanges);
5858
EXPECT_EQ(opt5.getKind(),
5959
SplitNodeOption::SplitNodeKind::SplitNodeBySliceRanges);
6060
SplitNodeOption *nonOrthogonalOpt = &opt5;
61-
EXPECT_EQ(nullptr, dyn_cast<SplitNodeOptionOrthogonal>(nonOrthogonalOpt));
62-
EXPECT_NE(nullptr, dyn_cast<SplitNodeBySliceRanges>(nonOrthogonalOpt));
61+
EXPECT_EQ(nullptr,
62+
llvm::dyn_cast<SplitNodeOptionOrthogonal>(nonOrthogonalOpt));
63+
EXPECT_NE(nullptr, llvm::dyn_cast<SplitNodeBySliceRanges>(nonOrthogonalOpt));
6364
}
6465

6566
/// Test for SplitNodeByNumChunks option.

0 commit comments

Comments
 (0)