Skipped failing tests on torch<2

Author: vfdev-5

tests/ignite/__init__.py

@@ -1,8 +1,12 @@
 import torch
+from packaging.version import Version
 
 from ignite.distributed.comp_models.base import _torch_version_gt_112
 
 
+_torch_version_lt_2 = Version(torch.__version__) < Version("2")
+
+
 def is_mps_available_and_functional():
     if not _torch_version_gt_112:
         return False

tests/ignite/contrib/engines/test_common.py

@@ -27,6 +27,7 @@
 )
 from ignite.engine import Engine, Events
 from ignite.handlers import DiskSaver, TerminateOnNan
+from tests.ignite import _torch_version_lt_2
 
 
 class DummyModel(nn.Module):
@@ -577,6 +578,7 @@ def test_setup_wandb_logging(dirname):
         setup_wandb_logging(MagicMock())
 
 
+@pytest.mark.skipif(_torch_version_lt_2, reason="CleamML tests are failing on torch<2")
 def test_setup_clearml_logging():
     handlers.clearml_logger.ClearMLLogger.set_bypass_mode(True)
 

tests/ignite/distributed/test_auto.py

@@ -12,7 +12,7 @@
 
 import ignite.distributed as idist
 from ignite.distributed.auto import auto_dataloader, auto_model, auto_optim, DistributedProxySampler
-from tests.ignite import is_mps_available_and_functional
+from tests.ignite import is_mps_available_and_functional, _torch_version_lt_2
 
 
 class DummyDS(Dataset):
@@ -310,8 +310,9 @@ def test_dist_proxy_sampler():
     with pytest.raises(TypeError, match=r"Argument sampler should be instance of torch Sampler"):
         DistributedProxySampler(None)
 
-    with pytest.raises(TypeError, match=r"Argument sampler should have length"):
-        DistributedProxySampler(Sampler())
+    if not _torch_version_lt_2:
+        with pytest.raises(TypeError, match=r"Argument sampler should have length"):
+            DistributedProxySampler(Sampler())
 
     with pytest.raises(TypeError, match=r"Argument sampler must not be a distributed sampler already"):
         DistributedProxySampler(DistributedSampler(sampler, num_replicas=num_replicas, rank=0))

tests/ignite/handlers/test_clearml_logger.py

@@ -24,6 +24,7 @@
     WeightsHistHandler,
     WeightsScalarHandler,
 )
+from tests.ignite import _torch_version_lt_2
 
 
 def test_no_clearml():
@@ -716,6 +717,7 @@ def weight_selector(n, _):
     assert mock_logger.grad_helper.add_histogram.call_count == 2
 
 
+@pytest.mark.skipif(_torch_version_lt_2, reason="CleamML tests are failing on torch<2")
 def test_integration(dirname):
     n_epochs = 5
     data = list(range(50))
@@ -743,6 +745,7 @@ def dummy_handler(engine, logger, event_name):
         logger.close()
 
 
+@pytest.mark.skipif(_torch_version_lt_2, reason="CleamML tests are failing on torch<2")
 def test_integration_as_context_manager(dirname):
     n_epochs = 5
     data = list(range(50))
@@ -768,6 +771,7 @@ def dummy_handler(engine, logger, event_name):
             trainer.run(data, max_epochs=n_epochs)
 
 
+@pytest.mark.skipif(_torch_version_lt_2, reason="CleamML tests are failing on torch<2")
 def test_clearml_logger_getattr_method(dirname):
     with pytest.warns(UserWarning, match="ClearMLSaver: running in bypass mode"):
         ClearMLLogger.set_bypass_mode(True)
@@ -789,6 +793,7 @@ def test_clearml_logger_getattr_method(dirname):
         logger.close()
 
 
+@pytest.mark.skipif(_torch_version_lt_2, reason="CleamML tests are failing on torch<2")
 def test_clearml_logger_get_task_bypass(dirname):
     with pytest.warns(UserWarning, match="ClearMLSaver: running in bypass mode"):
         ClearMLLogger.set_bypass_mode(True)