test

Author: goanpeca

ignite/handlers/base_logger.py

@@ -3,7 +3,6 @@
 import collections.abc as collections
 import numbers
 import warnings
-import weakref
 from abc import ABCMeta, abstractmethod
 from collections import OrderedDict
 from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union
@@ -262,34 +261,17 @@ def attach(
             :class:`~ignite.engine.events.RemovableEventHandle`, which can be used to remove the handler.
         """
         if isinstance(event_name, EventsList):
-            # Use weak reference to break circular reference: engine -> _event_handlers -> BaseLogger
-            # weak_self = weakref.ref(self)
-
-            # def weak_log_handler(engine, event_name):
-            #     logger_obj = weak_self()
-            #     if logger_obj is not None:
-            #         log_handler(engine, logger_obj, event_name)
-
             for name in event_name:
                 if name not in State.event_to_attr:
                     raise RuntimeError(f"Unknown event name '{name}'")
-                engine.add_event_handler(name, weak_log_handler, name)
+                engine.add_event_handler(name, log_handler, name)
 
             return RemovableEventHandle(event_name, log_handler, engine)
 
         else:
             if event_name not in State.event_to_attr:
                 raise RuntimeError(f"Unknown event name '{event_name}'")
 
-            # Use weak reference to break circular reference: engine -> _event_handlers -> BaseLogger
-            # weak_self = weakref.ref(self)
-
-            # def weak_log_handler(engine):
-            #     logger_obj = weak_self()
-            #     if logger_obj is not None:
-            #         log_handler(engine, logger_obj, event_name, *args, **kwargs)
-
-            # return engine.add_event_handler(event_name, weak_log_handler)
             return engine.add_event_handler(event_name, log_handler, self, event_name, *args, **kwargs)
 
     def attach_output_handler(self, engine: Engine, event_name: Any, *args: Any, **kwargs: Any) -> RemovableEventHandle:

ignite/handlers/tqdm_logger.py

@@ -2,7 +2,6 @@
 """TQDM logger."""
 from collections import OrderedDict
 from typing import Any, Callable, List, Optional, Union
-import weakref
 
 from ignite.engine import Engine, Events
 from ignite.engine.events import CallableEventWithFilter, RemovableEventHandle
@@ -224,15 +223,6 @@ def attach(  # type: ignore[override]
         super(ProgressBar, self).attach(engine, log_handler, event_name)
 
         engine.add_event_handler(closing_event_name, self._close)
-        # Use weak reference to break circular reference: engine -> _event_handlers -> ProgressBar
-        # weak_self = weakref.ref(self)
-
-        # def weak_close(engine):
-        #     pbar_obj = weak_self()
-        #     if pbar_obj is not None:
-        #         pbar_obj._close(engine)
-
-        # engine.add_event_handler(closing_event_name, weak_close)
 
     def attach_opt_params_handler(  # type: ignore[empty-body]
         self, engine: Engine, event_name: Union[str, Events], *args: Any, **kwargs: Any