Skip to content

Commit d6527a3

Browse files
committed
Update code review comments
1 parent c359e0c commit d6527a3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

ignite/engine/engine.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -433,15 +433,14 @@ def _fire_event(self, event_name: Any, *event_args: Any, **event_kwargs: Any) ->
433433
self.last_event_name = event_name
434434
for func, args, kwargs in self._event_handlers[event_name]:
435435
kwargs.update(event_kwargs)
436-
# Resolve weak references if present
437436
if args and isinstance(args[0], weakref.ref):
438437
resolved_engine = args[0]()
439438
if resolved_engine is None:
440-
# Engine was garbage collected, skip this handler
441-
continue
439+
raise RuntimeError("Engine reference not resolved. Cannot execute event handler.")
442440
first, others = ((resolved_engine,), args[1:])
443441
else:
444-
first, others = ((args[0],), args[1:]) if (args and args[0] == self) else (tuple(), args)
442+
raise ValueError("Invalid event handler.")
443+
445444
func(*first, *(event_args + others), **kwargs)
446445

447446
def fire_event(self, event_name: Any) -> None:

0 commit comments

Comments
 (0)