You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix static variable client access vialotion in DamonConfigLoader (#965)
Summary:
As discussed in pytorch issue [#129626](pytorch/pytorch#129626) , `updateThread` of `Config` will keep on accessing `client` after main thread quits. But when main thread quits, `client` will be destructed. Functions in `updateThread` may use a dangling pointer of `client`, which will cause invalid memory access, and finally, `Segment fault` occurs, a core file will be generated, which doesn't behave as expected.
Pull Request resolved: #965
Reviewed By: xuzhao9
Differential Revision: D60291572
Pulled By: aaronenyeshi
fbshipit-source-id: d97291aa825deeb672eb8e2d8385633c2838396d
0 commit comments