From 833e61b5325d75741dfa8da0bf2fe7962938f789 Mon Sep 17 00:00:00 2001 From: Shivam Raikundalia Date: Tue, 15 Oct 2024 09:26:41 -0700 Subject: [PATCH] pr comments --- libkineto/src/CuptiActivityProfiler.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libkineto/src/CuptiActivityProfiler.cpp b/libkineto/src/CuptiActivityProfiler.cpp index 702bff012..0f742d4ee 100644 --- a/libkineto/src/CuptiActivityProfiler.cpp +++ b/libkineto/src/CuptiActivityProfiler.cpp @@ -1299,16 +1299,15 @@ const time_point CuptiActivityProfiler::performRunLoopStep( ) { // Update runloop state first to prevent further updates to shared state LOG(INFO) << "Tracing complete."; - VLOG_IF(1, currentIter > 0) + VLOG_IF(1, currentIter >= 0) << "This state change was invoked by application's step() call"; - // currentIter > 0 means this is an iteration-based collection, + // currentIter >= 0 means this is an iteration-based collection, // triggered by pytorch main thread, it should be executed in another // thread in case pytorch main thread is blocked - if (currentIter > 0) { + if (currentIter >= 0) { // if collectTraceThread_ is already running, there's no need to // execute collectTrace twice. - LOG(WARNING) << "LAUNCHING THREAD FOR collectTrace()"; if (!collectTraceThread_) { std::lock_guard guard(mutex_); collectTraceThread_ = std::make_unique(