diff --git a/libkineto/include/Config.h b/libkineto/include/Config.h index 933b1d517..9866f8902 100644 --- a/libkineto/include/Config.h +++ b/libkineto/include/Config.h @@ -394,7 +394,7 @@ class Config : public AbstractConfig { return customConfig_; } - uint32_t maxEvents() const { + uint64_t maxEvents() const { return maxEvents_; } @@ -533,7 +533,7 @@ class Config : public AbstractConfig { std::string customConfig_; // Roctracer settings - uint32_t maxEvents_{5000000}; + uint64_t maxEvents_{5000000}; }; constexpr char kUseDaemonEnvVar[] = "KINETO_USE_DAEMON"; diff --git a/libkineto/src/Config.cpp b/libkineto/src/Config.cpp index 2a0c95fbe..59c61f312 100644 --- a/libkineto/src/Config.cpp +++ b/libkineto/src/Config.cpp @@ -442,7 +442,7 @@ bool Config::handleOption(const std::string& name, std::string& val) { } else if (!name.compare(kRequestGroupTraceID)) { requestGroupTraceID_ = val; } else if (!name.compare(kRoctracerSetMaxEvents)) { - maxEvents_ = toInt32(val); + maxEvents_ = toInt64(val); } // TODO: Deprecate Client Interface diff --git a/libkineto/src/RoctracerActivityApi.cpp b/libkineto/src/RoctracerActivityApi.cpp index 0bec09d4a..c9d069588 100644 --- a/libkineto/src/RoctracerActivityApi.cpp +++ b/libkineto/src/RoctracerActivityApi.cpp @@ -175,7 +175,7 @@ void RoctracerActivityApi::clearActivities() { d->clearLogs(); } -void RoctracerActivityApi::setMaxEvents(uint32_t maxEvents) { +void RoctracerActivityApi::setMaxEvents(uint64_t maxEvents) { #ifdef HAS_ROCTRACER d->setMaxEvents(maxEvents); #endif diff --git a/libkineto/src/RoctracerActivityApi.h b/libkineto/src/RoctracerActivityApi.h index 54bf03f73..e96325a5b 100644 --- a/libkineto/src/RoctracerActivityApi.h +++ b/libkineto/src/RoctracerActivityApi.h @@ -45,7 +45,7 @@ class RoctracerActivityApi { void clearActivities(); void flushActivities(); void teardownContext() {} - void setMaxEvents(uint32_t maxEvents); + void setMaxEvents(uint64_t maxEvents); virtual int processActivities( std::function handler, diff --git a/libkineto/src/RoctracerLogger.cpp b/libkineto/src/RoctracerLogger.cpp index 725c4d0b0..8321b83d9 100644 --- a/libkineto/src/RoctracerLogger.cpp +++ b/libkineto/src/RoctracerLogger.cpp @@ -311,7 +311,7 @@ void RoctracerLogger::activity_callback( } } -void RoctracerLogger::setMaxEvents(uint32_t maxBufferSize) { +void RoctracerLogger::setMaxEvents(uint64_t maxBufferSize) { #ifdef HAS_ROCTRACER RoctracerLogger* dis = &singleton(); std::lock_guard lock(dis->rowsMutex_); diff --git a/libkineto/src/RoctracerLogger.h b/libkineto/src/RoctracerLogger.h index d28a9f08b..9d075892d 100644 --- a/libkineto/src/RoctracerLogger.h +++ b/libkineto/src/RoctracerLogger.h @@ -267,7 +267,7 @@ class RoctracerLogger { void startLogging(); void stopLogging(); void clearLogs(); - void setMaxEvents(uint32_t maxBufferSize); + void setMaxEvents(uint64_t maxBufferSize); private: bool registered_{false}; @@ -285,7 +285,7 @@ class RoctracerLogger { ApiIdList loggedIds_; // Api callback data - uint32_t maxBufferSize_{5000000}; // 5M GPU runtime/kernel events. + uint64_t maxBufferSize_{5000000}; // 5M GPU runtime/kernel events. std::vector rows_; std::mutex rowsMutex_;