Skip to content

Green Light PR Review #155

Green Light PR Review

Green Light PR Review #155

Manually triggered August 24, 2026 14:32
Status Success
Total duration 6m 5s
Artifacts 1

greenlight-pr-review.yml

on: workflow_dispatch
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 3 warnings
review
Unable to download artifact(s):\\nArtifact not found for name: libtorch-cuda13_2-shared-with-deps-release\\n```\\n\\nThis is not a new break. Until the recent `continue-on-error` change in `_binary-upload.yml`, the download failure was swallowed and \\\"Upload binaries\\\" reported success having uploaded nothing — so libtorch nightlies had silently not been publishing on branch pushes. That change didn't cause this; it made it visible.\\n\\n## Test plan\\n\\n- Regenerated with `.github/regenerate.sh`; the only generated change is the single `if:` line in `generated-linux-binary-manywheel-nightly.yml` (it is the only workflow with `libtorch_extraction_configs`).\\n- Re-running the generator produces no further diff, so the checked-in file is in sync.\\n- `yaml.safe_load` on the regenerated workflow parses; 24 jobs; `libtorch-extract.if` is now `${{ !failure() && !cancelled() && github.repository_owner == 'pytorch' }}`.\\n\\nNote this cannot be meaningfully validated by `workflow_dispatch`: on a manual run `github.ref_type` is `branch`, so `get-docker-tag` skips the same way, and `event_name != 'push'` makes `continue-on-error` evaluate true, so the uploads would go green without uploading anything. A `ciflow/binaries_libtorch/*` tag exercises the full chain, and the next nightly is the real confirmation.\\n\\n## Follow-up (deliberately not in this PR)\\n\\n`libtorch-upload` uses `owner_if`, which tolerates a **skipped** dependency — that is why seven uploads ran against a missing artifact rather than being skipped themselves. Adding `needs.libtorch-extract.result == 'success'` would collapse seven confusing red uploads into one signal at the real failure point. Kept separate so this minimal fix can land quickly and restore the artifacts.\\n\",\n \"head_sha\": \"ae3bffb399eff40ecd9772ce475273818d6f2f5b\",\n \"comments\": [\n {\n \"author\": \"pytorch-bot\",\n \"body\": \"<!-- drci-comment-start -->\\n\\n## :link: Helpful Links\\n### :test_tube: See artifacts and rendered test results at [hud.pytorch.org/pr/194610](https://hud.pytorch.org/pr/194610)\\n* :page_facing_up: Preview [Python docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/194610/index.html)\\n* :page_facing_up: Preview [C++ docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/194610/cppdocs/index.html)\\n* :question: Need help or want to give feedback on the CI? Visit the [bot commands wiki](https://github.com/pytorch/pytorch/wiki/Bot-commands)\\n\\nNote: Links to docs will display an error until the docs builds have been completed.\\n\\n\\n\\n\\nThis comment was automatically generated by Dr. CI and updates every 15 minutes.\\n<!-- drci-comment-end -->\",\n \"createdAt\": \"2026-08-24T14:29:45Z\"\n },\n {\n \"author\": \"pytorchgreenlight\",\n \"body\": \"<!-- greenlight-verdict -->\\n<!-- greenlight-run: 32739353217 -->\\n**Green Light review in progress**\\n\\n<details>\\n<summary>Details</summary>\\n\\nGreen Light is reviewing this PR.\\n\\n[Inference job](https://github.com/pytorch/test-infra/actions/runs/32739353217)\\n</details>\",\n \"createdAt\": \"2026-08-24T14:33:07Z\"\n }\n ]\n}\n",
review
Unable to download artifact(s):\\nArtifact not found for name: libtorch-cuda13_2-shared-with-deps-release\\n```\\n\\nThis is not a new break. Until the recent `continue-on-error` change in `_binary-upload.yml`, the download failure was swallowed and \\\"Upload binaries\\\" reported success having uploaded nothing — so libtorch nightlies had silently not been publishing on branch pushes. That change didn't cause this; it made it visible.\\n\\n## Test plan\\n\\n- Regenerated with `.github/regenerate.sh`; the only generated change is the single `if:` line in `generated-linux-binary-manywheel-nightly.yml` (it is the only workflow with `libtorch_extraction_configs`).\\n- Re-running the generator produces no further diff, so the checked-in file is in sync.\\n- `yaml.safe_load` on the regenerated workflow parses; 24 jobs; `libtorch-extract.if` is now `${{ !failure() && !cancelled() && github.repository_owner == 'pytorch' }}`.\\n\\nNote this cannot be meaningfully validated by `workflow_dispatch`: on a manual run `github.ref_type` is `branch`, so `get-docker-tag` skips the same way, and `event_name != 'push'` makes `continue-on-error` evaluate true, so the uploads would go green without uploading anything. A `ciflow/binaries_libtorch/*` tag exercises the full chain, and the next nightly is the real confirmation.\\n\\n## Follow-up (deliberately not in this PR)\\n\\n`libtorch-upload` uses `owner_if`, which tolerates a **skipped** dependency — that is why seven uploads ran against a missing artifact rather than being skipped themselves. Adding `needs.libtorch-extract.result == 'success'` would collapse seven confusing red uploads into one signal at the real failure point. Kept separate so this minimal fix can land quickly and restore the artifacts.\\n\",\n5\t \"head_sha\": \"ae3bffb399eff40ecd9772ce475273818d6f2f5b\",\n6\t \"comments\": [\n7\t {\n8\t \"author\": \"pytorch-bot\",\n9\t \"body\": \"<!-- drci-comment-start -->\\n\\n## :link: Helpful Links\\n### :test_tube: See artifacts and rendered test results at [hud.pytorch.org/pr/194610](https://hud.pytorch.org/pr/194610)\\n* :page_facing_up: Preview [Python docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/194610/index.html)\\n* :page_facing_up: Preview [C++ docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/194610/cppdocs/index.html)\\n* :question: Need help or want to give feedback on the CI? Visit the [bot commands wiki](https://github.com/pytorch/pytorch/wiki/Bot-commands)\\n\\nNote: Links to docs will display an error until the docs builds have been completed.\\n\\n\\n\\n\\nThis comment was automatically generated by Dr. CI and updates every 15 minutes.\\n<!-- drci-comment-end -->\",\n10\t \"createdAt\": \"2026-08-24T14:29:45Z\"\n11\t },\n12\t {\n13\t \"author\": \"pytorchgreenlight\",\n14\t \"body\": \"<!-- greenlight-verdict -->\\n<!-- greenlight-run: 32739353217 -->\\n**Green Light review in progress**\\n\\n<details>\\n<summary>Details</summary>\\n\\nGreen Light is reviewing this PR.\\n\\n[Inference job](https://github.com/pytorch/test-infra/actions/runs/32739353217)\\n</details>\",\n15\t \"createdAt\": \"2026-08-24T14:33:07Z\"\n16\t }\n17\t ]\n18\t}\n19\t"
announce_start
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@11d5960a326750d5838078e36cf38b85af677262, actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349, actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065, aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@11d5960a326750d5838078e36cf38b85af677262, actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02, aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
record
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@11d5960a326750d5838078e36cf38b85af677262, actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349, actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093, actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065, aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Artifacts

Produced during runtime
Name Size Digest
greenlight-verdict
685 Bytes
sha256:340e3e6a19210c19f80ad71acac20205958850adff77b417c426bd250bfefe91