Skip to content

Commit 00b05fc

Browse files
committed
Keep the PyPI-sourced CUDA deps in PACKAGE_LINKS_ALLOW_LIST only
cuda_python, cuda_bindings, cuda_pathfinder, cuda_toolkit and nvidia_ml_py appeared in both allow lists. They are sourced from PyPI by update_dependencies.py, so their index is meant to be copied from the parent rather than regenerated: that is what #8483 added them to PACKAGE_LINKS_ALLOW_LIST for. It left them in PACKAGE_ALLOW_LIST, which keeps manage_v2 generating an index for them from whatever wheels it finds, competing with the copied one. They were the only five entries present in both lists; the links list is untouched, so all five still get copied into the arch subdirectories. whl/test/cu134 currently advertises cuda-pathfinder and cuda-python in its listing while both targets 403.
1 parent c22f7fa commit 00b05fc

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

s3_management/manage_v2.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,12 +286,12 @@
286286
"flash_attn_3",
287287
# vllm
288288
"ninja",
289-
"cuda_python",
290-
"cuda_bindings",
291-
"cuda_pathfinder",
292-
"cuda_toolkit",
289+
# cuda_python, cuda_bindings, cuda_pathfinder, cuda_toolkit and
290+
# nvidia_ml_py are sourced from PyPI by update_dependencies.py and live
291+
# in PACKAGE_LINKS_ALLOW_LIST only. Listing them here as well makes
292+
# manage_v2 regenerate their index from whatever wheels it finds,
293+
# competing with the copied one.
293294
"pynvml",
294-
"nvidia_ml_py",
295295
"einops",
296296
"packaging",
297297
"nvidia_cudnn_frontend",

0 commit comments

Comments
 (0)