update

Author: KarhouTam

aws/lambda/cross_repo_ci_relay/utils/gh_helper.py

@@ -143,7 +143,7 @@ def build_check_run_output(
     conclusion: str,
     details_url: str,
     downstream_repo: str,
-    pr_number: str
+    pr_number: str = "",
 ) -> dict:
     """Return a GitHub Check Run output dict shown in the detail panel."""
     if status != "completed":
@@ -152,9 +152,10 @@ def build_check_run_output(
         title = conclusion.capitalize()
     else:
         title = "Completed"
+    pr_part = f" for PR {pr_number}" if pr_number else ""
     return {
         "title": title,
-        "summary": f"{downstream_repo} workflow for PR {pr_number}: {details_url}",
+        "summary": f"{downstream_repo} workflow{pr_part}: {details_url}",
     }
 
 

torchci/lib/bot/crcrOncallBot.ts

@@ -81,14 +81,18 @@ export default function crcrOncallBot(app: Probot): void {
 
     // Get the PRs this check run belongs to.
     let prNumbers: number[] = [];
-    if (checkRun.pull_requests && checkRun.pull_requests.length > 0) {
-      prNumbers = checkRun.pull_requests.map((pr) => pr.number);
-    } else if (checkRun.output?.summary) {
+    if (checkRun.output?.summary) {
       const match = checkRun.output.summary.match(/for PR (\d+)/);
       if (match) {
         prNumbers = [parseInt(match[1], 10)];
       }
-    } else if (checkRun.head_sha) {
+    } else if (checkRun.pull_requests && checkRun.pull_requests.length > 0) {
+      prNumbers = checkRun.pull_requests.map((pr) => pr.number);
+    }
+
+    // Fall back to Search API if still no PR found (e.g., pr_number was empty
+    // on the Lambda side).
+    if (prNumbers.length === 0 && checkRun.head_sha) {
       try {
         const result = await ctx.octokit.rest.search.issuesAndPullRequests({
           q: `${checkRun.head_sha} type:pr repo:${owner}/${repo}`,

torchci/test/crcrOncallBot.test.ts

@@ -177,6 +177,13 @@ L3:
   });
 
   test("does not comment when output has no PR number", async () => {
+    // output.summary exists but regex doesn't match (empty pr_number);
+    // falls through to Search API which also returns nothing
+    const scope = nock("https://api.github.com")
+      .get("/search/issues")
+      .query(true)
+      .reply(200, { total_count: 0, items: [] });
+
     await probot.receive({
       name: "check_run" as any,
       payload: checkRunPayload({
@@ -188,6 +195,7 @@ L3:
       }) as any,
       id: "8",
     });
+    handleScope(scope);
   });
 
   test("posts comment when output contains PR number for cross-fork PR", async () => {