[autorevert] Fix bug on job retrival for autorevert lambda

Author: jeanschmidt

aws/lambda/pytorch-auto-revert/Makefile

@@ -23,7 +23,7 @@ run-local: venv/bin/python
 
 .PHONY: run-local-workflows
 run-local-workflows: venv/bin/python
-	venv/bin/python -m pytorch_auto_revert workflows pull.yml
+	venv/bin/python -m pytorch_auto_revert autorevert-checker Lint trunk pull inductor linux-binary-manywheel --hours 4320
 
 deployment.zip:
 	mkdir -p deployment

aws/lambda/pytorch-auto-revert/pytorch_auto_revert/__main__.py

@@ -159,8 +159,14 @@ def main(*args, **kwargs) -> None:
             "ClickHouse connection test failed. Please check your configuration."
         )
 
-    if opts.subcommand == "lambda":
-        print("TODO: run lambda flow")
+    if opts.subcommand is None:
+        autorevert_checker(
+            ["Lint", "trunk", "pull", "inductor", "linux-binary-manywheel", ],
+            hours=2,
+            verbose=True,
+            do_restart=True,
+            dry_run=False,
+        )
     elif opts.subcommand == "autorevert-checker":
         autorevert_checker(
             opts.workflows,

aws/lambda/pytorch-auto-revert/pytorch_auto_revert/autorevert_checker.py

@@ -70,7 +70,7 @@ def __init__(self, workflow_names: List[str] = None, lookback_hours: int = 48):
         self._commit_history = None
 
     def get_workflow_commits(self, workflow_name: str) -> List[CommitJobs]:
-        """Get workflow commits for a specific workflow, fetching if needed."""
+        """Get workflow commits for a specific workflow, fetching if needed. From newer to older"""
         if workflow_name not in self._workflow_commits_cache:
             self._fetch_workflow_data()
         return self._workflow_commits_cache.get(workflow_name, [])
@@ -90,7 +90,7 @@ def commit_history(self) -> List[Dict]:
         return self._commit_history or []
 
     def _fetch_workflow_data(self):
-        """Fetch workflow job data from ClickHouse for all workflows in batch."""
+        """Fetch workflow job data from ClickHouse for all workflows in batch. From newer to older"""
         if not self.workflow_names:
             return
 
@@ -217,11 +217,11 @@ def _find_last_commit_with_job(
             for job in commit.jobs:
                 if job.name.split("(")[0] == job_name:  # Normalize job name
                     job_results.append(job)
-        if job_results:
-            return (
-                commit,
-                job_results,
-            )
+            if job_results:
+                return (
+                    commit,
+                    job_results,
+                )
         return None, None
 
     def detect_autorevert_pattern_workflow(self, workflow_name: str) -> List[Dict]:
@@ -304,18 +304,11 @@ def detect_autorevert_pattern_workflow(self, workflow_name: str) -> List[Dict]:
                     # No older commit with the same job found
                     continue
 
-                if any(
-                    j.name.split("(")[0] != job_name
-                    for j in last_commit_with_same_job.failed_jobs
-                ):
-                    # newr commit has the same job failing
-                    continue
-
                 if any(
                     j.classification_rule == suspected_failure_class_rule
                     for j in last_same_jobs
                 ):
-                    # The last commit with the same job has the same failure classification
+                    # The older commit has the same job failing with same rule
                     continue
 
                 patterns.append(

aws/lambda/pytorch-auto-revert/pytorch_auto_revert/testers/autorevert.py

@@ -108,7 +108,7 @@ def autorevert_checker(
                     "category", "uncategorized"
                 )
                 print(
-                    f"✓ REVERTED ({category}): {second_commit[:8]} was reverted by {revert_result['revert_sha'][:8]} "
+                    f"✓ REVERTED ({category}): {second_commit} was reverted by {revert_result['revert_sha'][:8]} "
                     f"after {revert_result['hours_after_target']:.1f} hours"
                 )
                 reverted_patterns.append(pattern)