Upgrade runner-binaries-syncer to aws sdk v3 (#7078)

`yarn test` is broken on main, you can see this in
https://github.com/pytorch/test-infra/blob/a32b8f647ed2df0e93a167e518cf92f5855671ce/terraform-aws-github-runner/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/Makefile#L15


Testing:
Stole some environment variables from the lambda and mangled the key to
upload to a dummy key then ran `yarn build; cd dist;node -e
'require("./index").handler();' > t.log`
Saw that it uploaded a file, and skipped some because they didn't need
to be uploaded.
The one that was uploaded was arm64, which I'm thinking was uploaded
manually since it lacks a tag on s3.

I had to add an `await` since it wasn't working, which I think is a bug
in the original code

Author: clee2000

terraform-aws-github-runner/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/package.json

@@ -21,8 +21,6 @@
     "@types/request": "^2.48.4",
     "@typescript-eslint/eslint-plugin": "^4.17.0",
     "@typescript-eslint/parser": "^4.17.0",
-    "@zeit/ncc": "^0.22.1",
-    "aws-sdk": "^2.863.0",
     "eslint": "^7.22.0",
     "jest": "^26.6.3",
     "prettier": "^2.4.1",
@@ -31,6 +29,9 @@
     "typescript": "^4.2.3"
   },
   "dependencies": {
+    "@aws-sdk/client-s3": "^3.879.0",
+    "@aws-sdk/lib-storage": "^3.879.0",
+    "@vercel/ncc": "^0.38.3",
     "request": "^2.88.2",
     "yn": "^4.0.0"
   }

terraform-aws-github-runner/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/syncer/handler.ts

@@ -1,8 +1,8 @@
 import { Octokit } from '@octokit/rest';
 import { PassThrough } from 'stream';
 import request from 'request';
-import { S3 } from 'aws-sdk';
-import AWS from 'aws-sdk';
+import { S3, Tag } from '@aws-sdk/client-s3';
+import { Upload } from '@aws-sdk/lib-storage';
 import yn from 'yn';
 
 const versionKey = 'name';
@@ -14,14 +14,12 @@ interface CacheObject {
 
 async function getCachedVersion(s3: S3, cacheObject: CacheObject): Promise<string | undefined> {
   try {
-    const objectTagging = await s3
-      .getObjectTagging({
-        Bucket: cacheObject.bucket,
-        Key: cacheObject.key,
-      })
-      .promise();
-    const versions = objectTagging.TagSet?.filter((t: S3.Tag) => t.Key === versionKey);
-    return versions.length === 1 ? versions[0].Value : undefined;
+    const objectTagging = await s3.getObjectTagging({
+      Bucket: cacheObject.bucket,
+      Key: cacheObject.key,
+    });
+    const versions = objectTagging.TagSet?.filter((t: Tag) => t.Key === versionKey);
+    return versions?.length === 1 ? versions[0].Value : undefined;
   } catch (e) {
     console.debug('No tags found');
     return undefined;
@@ -65,12 +63,16 @@ async function getReleaseAsset(
 
 async function uploadToS3(s3: S3, cacheObject: CacheObject, actionRunnerReleaseAsset: ReleaseAsset): Promise<void> {
   const writeStream = new PassThrough();
-  s3.upload({
-    Bucket: cacheObject.bucket,
-    Key: cacheObject.key,
-    Tagging: versionKey + '=' + actionRunnerReleaseAsset.name,
-    Body: writeStream,
-  }).promise();
+  const upload = new Upload({
+    client: s3,
+    params: {
+      Bucket: cacheObject.bucket,
+      Key: cacheObject.key,
+      Tagging: `${versionKey}=${actionRunnerReleaseAsset.name}`,
+      Body: writeStream,
+    },
+  });
+  const uploadPromise = upload.done();
 
   await new Promise<void>((resolve, reject) => {
     console.debug('Start downloading %s and uploading to S3.', actionRunnerReleaseAsset.name);
@@ -87,10 +89,11 @@ async function uploadToS3(s3: S3, cacheObject: CacheObject, actionRunnerReleaseA
   }).catch((error) => {
     console.error(`Exception: ${error}`);
   });
+  await uploadPromise;
 }
 
 export const handle = async (): Promise<void> => {
-  const s3 = new AWS.S3();
+  const s3 = new S3();
 
   const fetchPrereleaseBinaries = yn(process.env.GITHUB_RUNNER_ALLOW_PRERELEASE_BINARIES, { default: false });
   const distributions = [
@@ -131,7 +134,7 @@ export const handle = async (): Promise<void> => {
     const currentVersion = await getCachedVersion(s3, cacheObject);
     console.debug('latest: ' + currentVersion);
     if (currentVersion === undefined || currentVersion != actionRunnerReleaseAsset.name) {
-      uploadToS3(s3, cacheObject, actionRunnerReleaseAsset);
+      await uploadToS3(s3, cacheObject, actionRunnerReleaseAsset);
     } else {
       console.debug('Distribution is up-to-date, no action.');
     }