Skip to content

Commit 20f8996

Browse files
[vllm-triage] Fix test regresssion (#8527)
The following tests broke due to multiple different merges on main. The fixes are purely test side and won't effect actually using the workflow. Just had to add some additional data to the the fixture. tests/test_vllm_torch_nightly_triage.py::TestRenderRegressedTests::test_no_section_when_empty tests/test_vllm_torch_nightly_triage.py::TestRenderRegressedTests::test_section_present_when_regressed_tests tests/test_vllm_torch_nightly_triage.py::TestReportJsonWiring::test_json_has_regressed_tests_key
1 parent a60fe0c commit 20f8996

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

tools/torchci/tests/test_vllm_torch_nightly_triage.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,12 @@ def _tn_base(self):
315315
"state": "failed",
316316
"commit": "b706fd1628b0abcdef",
317317
}
318-
base = {"number": 82790, "url": "u_base", "state": "failed"}
318+
base = {
319+
"number": 82790,
320+
"url": "u_base",
321+
"state": "failed",
322+
"commit": "b706fd1628b0abcdef",
323+
}
319324
return tn, base
320325

321326
def test_section_present_when_regressed_tests(self) -> None:
@@ -348,7 +353,12 @@ def test_json_has_regressed_tests_key(self) -> None:
348353
"state": "failed",
349354
"commit": "b706fd1628b0abcdef",
350355
}
351-
base = {"number": 82790, "url": "u_base", "state": "failed"}
356+
base = {
357+
"number": 82790,
358+
"url": "u_base",
359+
"state": "failed",
360+
"commit": "b706fd1628b0abcdef",
361+
}
352362
# A `both` job so main() decides to fetch logs (the diff path).
353363
buckets = {
354364
"regressed": [],

0 commit comments

Comments
 (0)