Commit 2dc447a
authored
[torchci] Fix yarn format broken on main (unparseable
`yarn format` is failing on `main` after #8213. The advisor verdict maps
used the TS `satisfies` operator, which the repo's prettier version
can't parse — prettier throws `SyntaxError: ',' expected` on `}
satisfies Record<...>` and `yarn format` exits non-zero (e.g. [this
run](https://github.com/pytorch/test-infra/actions/runs/28980734998/job/85998682132)).
It turns out that I use node 26 locally while CI use node 24.
**Fix:** replace `{...} satisfies Record<AdvisorVerdictType, …>` with a
direct `Record<AdvisorVerdictType, …>` type annotation on the three
verdict maps (`AutorevertCell`, `AiAdvisorIndicator`, `AdvisorSection`).
This keeps the same compile-time exhaustiveness — `tsc` still errors if
a future verdict is added without updating a map — but uses syntax
prettier understands.
No behavior change. `prettier --check` and `tsc --noEmit` both pass
locally.satisfies) (#8272)1 parent cb9f8ca commit 2dc447a
3 files changed
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | | - | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
| 79 | + | |
83 | 80 | | |
84 | | - | |
| 81 | + | |
85 | 82 | | |
86 | 83 | | |
87 | 84 | | |
88 | 85 | | |
89 | 86 | | |
90 | 87 | | |
91 | | - | |
| 88 | + | |
92 | 89 | | |
93 | 90 | | |
94 | 91 | | |
| |||
0 commit comments