Commit 3987ba1
authored
Don't advertise CUDA 13.4 on the getting-started page (#8499)
`update-quick-start-module.yml` in pytorch/pytorch.github.io calls
`generate_binary_build_matrix.yml@main` with `getting-started: true` for
linux/windows/macos-arm64 on the nightly and release channels, and
publishes the result as the pytorch.org install selector.
Because 13.4 is in `CUDA_ARCHES_DICT["nightly"]`, that bot has started
adding a `cu134` option — see pytorch/pytorch.github.io#2130, which
introduces:
```
pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu134
```
13.4 is built and validated, but it is not ready to be offered to users,
so this gates it out of **the getting-started matrix only**.
## Approach
`initialize_globals` already accepted a `getting_started` argument that
was never used — this gives it a purpose. The filter follows the
existing `CUDA_ARCHES_NO_WINDOWS` convention immediately above it:
```python
CUDA_ARCHES_NO_GETTING_STARTED = ["13.4"]
```
To re-enable 13.4 on the page later, drop it from that list — no other
change needed.
`CUDA_AARCH64_ARCHES` is deliberately untouched: the getting-started
workflow never requests `linux-aarch64`, and that list is a module
constant with no per-channel dict behind it, so filtering it in place
would leak into later calls in the same process.
## Test plan
- `python -m tools.tests.test_generate_binary_build_matrix` — 11 tests
pass.
- `--update-reference-files` — no asset changes.
- Getting-started matrix (`--getting-started true`), `cu134` entry count
before -> after, across all six jobs the quick-start workflow runs:
| os | channel | before | after |
| --- | --- | --- | --- |
| linux | nightly | **2** | **0** |
| linux | release | 0 | 0 |
| windows | nightly / release | 0 | 0 |
| macos-arm64 | nightly / release | 0 | 0 |
The two linux/nightly entries are the wheel + libtorch options #2130 was
adding. Windows was already 0 via `CUDA_ARCHES_NO_WINDOWS`.
- **Non**-getting-started matrices are byte-identical (md5) for `{linux,
linux-aarch64, windows, macos-arm64}` x `{nightly, test, release}` —
builds and binary validation are unaffected.
- Verified the filter does not leak across calls: after a
`getting_started=True` call, a subsequent default call still sees
`['12.6', '13.0', '13.2', '13.4']`.
Authored with the assistance of Claude Code.1 parent 00fa578 commit 3987ba1
1 file changed
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
78 | 85 | | |
79 | 86 | | |
80 | 87 | | |
| |||
181 | 188 | | |
182 | 189 | | |
183 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
184 | 195 | | |
185 | 196 | | |
186 | 197 | | |
| |||
0 commit comments