Skip to content

Commit 471dc2e

Browse files
authored
[Helion Benchmark] Highlight the best speedup per row (#7128)
1 parent 14b4c56 commit 471dc2e

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

torchci/components/benchmark/llms/components/LLMsSummaryPanel.tsx

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,11 +315,29 @@ export default function LLMsSummaryPanel({
315315
const l = v.l.actual;
316316
const r = v.r.actual;
317317

318-
if (!v.highlight) {
318+
if (!v.highlight && benchmarkName !== "Helion Benchmark") {
319319
return "";
320320
}
321321

322322
if (lCommit === rCommit) {
323+
if (benchmarkName === "Helion Benchmark") {
324+
// Highlight the fastest speedup
325+
if (metric.endsWith("_speedup")) {
326+
let maxKey: string | null = null;
327+
let maxValue: number = -Infinity;
328+
for (const key in params.row) {
329+
if (
330+
key.endsWith("_speedup") &&
331+
params.row[key].r.actual_geomean > maxValue
332+
) {
333+
maxKey = key;
334+
maxValue = params.row[key].r.actual_geomean;
335+
}
336+
}
337+
return maxKey === metric ? styles.ok : "";
338+
}
339+
}
340+
323341
return "";
324342
} else {
325343
if (l === r) {

0 commit comments

Comments
 (0)