Commit 52d2b92
authored
Add a job summary listing promoted files to the release workflows (#8479)
The three release workflows -- `release-download-pytorch-org.yml`,
`release-stage-pypi.yml` and `release-pypi.yml` -- print their S3
transfers into a step log and nothing else. Finding out what a promotion
actually moved means expanding the step and scrolling past `--debug`
output and xtrace noise, and after a partial failure it means diffing
the bucket by hand.
This adds a job summary to each of them, listing every file the run
transferred, grouped into collapsed sections by destination directory.
Each promotion step now tees its transfer output to a log under
`${RUNNER_TEMP}`, and a new `release/summarize_promoted_files.sh` parses
the `copy:` / `upload:` / `download:` lines out of it and writes
markdown to `${GITHUB_STEP_SUMMARY}`. Parsing the transfer log rather
than listing the destination afterwards means the summary reports what
this run moved, not whatever already happened to be there.
Details worth noting:
- The summary steps are `if: always()`, because a promotion that dies
partway through is exactly when you want to know which files already
made it.
- Dry runs are labelled with a banner and still list the files, since
`--dryrun` emits `(dryrun) copy:` lines carrying the real destinations.
- Zero transferred files gets an explicit callout instead of an empty
list -- that state means the source pattern matched nothing, which
currently passes silently.
- `set -ex` became `set -exo pipefail` in the teed steps so a failing
`aws` command is not masked by `tee` succeeding.
- Progress output is carriage-return delimited, so the script converts
CRs to newlines rather than stripping them; otherwise `Completed 3
file(s)...\rcopy: ...` would hide the transfer line.
Sample output:
> ## torchvision 0.27.1 - promoted to download.pytorch.org
>
> **Dry run** -- these transfers were simulated, nothing was published.
>
> **6 file(s) transferred.**
>
> <details><summary><code>s3://pytorch/whl/cu128</code> -- 2
file(s)</summary>
>
> - torchvision-0.27.1%2Bcu128-cp311-cp311-linux_x86_64.whl
> - torchvision-0.27.1%2Bcu128-cp312-cp312-linux_x86_64.whl
>
> </details>
### Test plan
Ran the script against a synthetic log covering CR-interleaved progress
lines, `(dryrun)` prefixes, a duplicate line from a retried transfer,
and two sibling destination directories sharing a prefix (`whl/cpu` and
`whl/cpu2`) -- output groups correctly, dedupes the retry, and keeps the
siblings apart. Also verified the empty-log and no-transfers paths.
`actionlint` (with `shellcheck` enabled) passes on all three workflows
and `shellcheck` passes on the new script.
Still needs a real `workflow_dispatch` dry run of each workflow to
confirm the AWS CLI output in these containers matches what the parser
expects.1 parent 1251e80 commit 52d2b92
4 files changed
Lines changed: 149 additions & 6 deletions
File tree
- .github/workflows
- release
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
100 | 101 | | |
101 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
102 | 120 | | |
103 | 121 | | |
104 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
63 | 64 | | |
64 | | - | |
| 65 | + | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
67 | 87 | | |
68 | 88 | | |
69 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
| 70 | + | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
72 | | - | |
| 74 | + | |
73 | 75 | | |
74 | 76 | | |
75 | 77 | | |
| |||
118 | 120 | | |
119 | 121 | | |
120 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
0 commit comments