Apply lint/format pass to advisor-coverage

- Reflow long lines and multi-line calls to satisfy formatter
- Convert dict(...) constructor to {} literal in test config helper
- Reorder config import alphabetically; drop stray blank lines
- Add noqa: G200 to logfilter HEAD-failure warning
- Wrap flaky_trunk argMax(...) verdict expression across lines

No behavior change — pure formatting/lint compliance across the
advisor_coverage lambda, its tests, and the flaky_trunk queries.

Signed-off-by: Jean Schmidt <contato@jschmidt.me>

Author: jeanschmidt

aws/lambda/pytorch-advisor-coverage/advisor_coverage/bootstrap.py

@@ -21,7 +21,6 @@
 
 import boto3
 import github
-
 from pytorch_auto_revert.clickhouse_client_helper import CHCliFactory
 from pytorch_auto_revert.github_client_helper import GHClientFactory
 from pytorch_auto_revert.utils import RetryWithBackoff
@@ -92,9 +91,7 @@ def _get_secret_from_aws(secret_store_name: str) -> _AWSSecrets:
         sys.exit(1)
 
 
-def _mint_scoped_installation_token(
-    app_id: str, pem: str, installation_id: int
-) -> str:
+def _mint_scoped_installation_token(app_id: str, pem: str, installation_id: int) -> str:
     """Mint an installation token scoped to `actions:write` only.
 
     Without token_permissions the mint inherits the App's full permission set

aws/lambda/pytorch-advisor-coverage/advisor_coverage/config.py

@@ -164,9 +164,7 @@ def _validate(self, *, require_backfill_window: bool = False) -> "CoverageConfig
                 f"{sorted(ALLOWED_REPOS)} — refusing to dispatch against it"
             )
         if self.mode not in ("ongoing", "backfill"):
-            raise ValueError(
-                f"mode must be 'ongoing' or 'backfill', got {self.mode!r}"
-            )
+            raise ValueError(f"mode must be 'ongoing' or 'backfill', got {self.mode!r}")
         if require_backfill_window and self.mode == "backfill":
             if self.as_of_start is None or self.as_of_end is None:
                 raise ValueError(

aws/lambda/pytorch-advisor-coverage/advisor_coverage/dispatcher.py

@@ -32,9 +32,7 @@
 log = logging.getLogger(__name__)
 
 
-def _in_emit_window(
-    ts: Optional[datetime], start: datetime, stop: datetime
-) -> bool:
+def _in_emit_window(ts: Optional[datetime], start: datetime, stop: datetime) -> bool:
     """True if `ts` is in [start, stop). Missing timestamps are kept."""
     if ts is None:
         return True
@@ -251,9 +249,7 @@ def _existing_verdicts(self, reds: List[RedSignal]) -> Set[Tuple[str, str]]:
         for attempt in RetryWithBackoff():
             with attempt:
                 res = CHCliFactory().client.query(query, parameters=params)
-                return {
-                    (str(row[0]).strip(), str(row[1])) for row in res.result_rows
-                }
+                return {(str(row[0]).strip(), str(row[1])) for row in res.result_rows}
 
     def _dispatch_one(
         self,

aws/lambda/pytorch-advisor-coverage/advisor_coverage/logfilter.py

@@ -53,5 +53,5 @@ def _log_content_length(job_id: int) -> Optional[int]:
         log.debug("[coverage] log HEAD %s → HTTP %s", job_id, e.code)
         return None
     except (urllib.error.URLError, ValueError, OSError) as e:
-        log.warning("[coverage] log HEAD %s failed: %s", job_id, e)
+        log.warning("[coverage] log HEAD %s failed: %s", job_id, e)  # noqa: G200
         return None

aws/lambda/pytorch-advisor-coverage/advisor_coverage/payload.py

@@ -22,8 +22,7 @@
     "at or after the suspect commit (newest first)"
 )
 _LABEL_SUCCESSFUL = (
-    "successful: baseline commits where this signal was GREEN "
-    "before the suspect commit"
+    "successful: baseline commits where this signal was GREEN before the suspect commit"
 )
 
 
@@ -33,9 +32,7 @@ def _fmt_ts(dt: Optional[datetime]) -> str:
     return dt.strftime("%Y-%m-%d %H:%M:%S UTC")
 
 
-def _event(
-    *, status: str, run: JobRun, repo_full_name: str
-) -> Dict[str, Any]:
+def _event(*, status: str, run: JobRun, repo_full_name: str) -> Dict[str, Any]:
     return {
         "status": status,
         "job_name": run.name,
@@ -48,9 +45,7 @@ def _event(
             f"https://github.com/{repo_full_name}/actions/runs/"
             f"{run.wf_run_id}/job/{run.job_id}"
         ),
-        "log_url": (
-            f"https://ossci-raw-job-status.s3.amazonaws.com/log/{run.job_id}"
-        ),
+        "log_url": (f"https://ossci-raw-job-status.s3.amazonaws.com/log/{run.job_id}"),
     }
 
 

aws/lambda/pytorch-advisor-coverage/advisor_coverage/sql.py

@@ -18,7 +18,6 @@
 identity the /flaky_trunk page joins on.
 """
 
-
 _CTE_TRUNK_COMMITS = r"""trunk_commits AS (
     SELECT
         tupleElement(head_commit, 'id') AS head_sha,

aws/lambda/pytorch-advisor-coverage/advisor_coverage/tests/test_advisor_coverage.py

@@ -14,10 +14,10 @@
 from advisor_coverage import config as config_mod
 from advisor_coverage.backfill import run_backfill
 from advisor_coverage.config import (
+    _parse_workflows,
     COVERAGE_SIGNAL_KEY_PREFIX,
     CoverageConfig,
     HARD_CAP_DISPATCHES,
-    _parse_workflows,
 )
 from advisor_coverage.dispatcher import CoverageDispatcher
 from advisor_coverage.enumeration import (
@@ -34,14 +34,14 @@ def T(minute: int) -> datetime:
 
 
 def make_config(**overrides) -> CoverageConfig:
-    defaults = dict(
-        repo_full_name="pytorch/pytorch",
-        workflows=[],
-        hours=24,
-        max_dispatches_per_run=10,
-        dispatch_gap_seconds=3,
-        dry_run=True,
-    )
+    defaults = {
+        "repo_full_name": "pytorch/pytorch",
+        "workflows": [],
+        "hours": 24,
+        "max_dispatches_per_run": 10,
+        "dispatch_gap_seconds": 3,
+        "dry_run": True,
+    }
     defaults.update(overrides)
     return CoverageConfig(**defaults)
 
@@ -96,7 +96,9 @@ def _urlopen_cm(status, content_length):
     """A fake urlopen() context manager for logfilter HEAD tests."""
     resp = MagicMock()
     resp.status = status
-    resp.headers = {} if content_length is None else {"Content-Length": str(content_length)}
+    resp.headers = (
+        {} if content_length is None else {"Content-Length": str(content_length)}
+    )
     cm = MagicMock()
     cm.__enter__.return_value = resp
     cm.__exit__.return_value = False
@@ -119,7 +121,9 @@ def __init__(
         self.reds = reds
         self.config = config or make_config()
         self.existing_rows = existing_rows or []
-        self.limit = limit if limit is not None else self.config.effective_max_dispatches()
+        self.limit = (
+            limit if limit is not None else self.config.effective_max_dispatches()
+        )
         self.dispatch_side_effect = dispatch_side_effect
         self.sleep_calls = []
         self.log_calls = []
@@ -238,11 +242,10 @@ def test_prefix_not_configurable(self):
         self.assertFalse(hasattr(cfg, "coverage_prefix"))
 
     def test_dispatch_guard_never_posts_native_key(self):
-        with _DispatchHarness([make_red()]) as h:
-            with patch("advisor_coverage.dispatcher.COVERAGE_SIGNAL_KEY_PREFIX", ""), patch(
-                "advisor_coverage.payload.COVERAGE_SIGNAL_KEY_PREFIX", ""
-            ):
-                stats = h.dispatcher.dispatch_for_window(T(0), T(59))
+        with _DispatchHarness([make_red()]) as h, patch(
+            "advisor_coverage.dispatcher.COVERAGE_SIGNAL_KEY_PREFIX", ""
+        ), patch("advisor_coverage.payload.COVERAGE_SIGNAL_KEY_PREFIX", ""):
+            stats = h.dispatcher.dispatch_for_window(T(0), T(59))
         self.assertEqual(stats.dispatched, 0)
         self.assertEqual(stats.errors, 1)
         h.dispatch_mock.assert_not_called()
@@ -423,13 +426,17 @@ def test_counters_count_successes_only(self):
 class TestConfig(unittest.TestCase):
     def test_hard_cap(self):
         self.assertEqual(
-            make_config(max_dispatches_per_run=10000, dispatch_gap_seconds=1).effective_max_dispatches(),
+            make_config(
+                max_dispatches_per_run=10000, dispatch_gap_seconds=1
+            ).effective_max_dispatches(),
             HARD_CAP_DISPATCHES,
         )
 
     def test_timeout_clamp(self):
         self.assertEqual(
-            make_config(max_dispatches_per_run=10000, dispatch_gap_seconds=3).effective_max_dispatches(),
+            make_config(
+                max_dispatches_per_run=10000, dispatch_gap_seconds=3
+            ).effective_max_dispatches(),
             87,
         )
 
@@ -456,7 +463,12 @@ def test_workflows_env_and_event(self):
 
     def test_lowercase_event_overrides(self):
         cfg = CoverageConfig.from_env_and_event(
-            {"mode": "backfill", "hours": 48, "as_of_start": "2026-01-01", "as_of_end": "2026-01-05"}
+            {
+                "mode": "backfill",
+                "hours": 48,
+                "as_of_start": "2026-01-01",
+                "as_of_end": "2026-01-05",
+            }
         )
         self.assertEqual(cfg.mode, "backfill")
         self.assertEqual(cfg.hours, 48)
@@ -480,7 +492,11 @@ def test_backfill_requires_as_of_window(self):
     def test_backfill_as_of_must_be_ordered(self):
         with self.assertRaises(ValueError):
             CoverageConfig.from_env_and_event(
-                {"mode": "backfill", "as_of_start": "2026-01-05", "as_of_end": "2026-01-01"}
+                {
+                    "mode": "backfill",
+                    "as_of_start": "2026-01-05",
+                    "as_of_end": "2026-01-01",
+                }
             )
 
 
@@ -496,22 +512,68 @@ def _result(self, columns, rows):
 
     def test_assembles_red_with_baselines_before(self):
         unc_cols = [
-            "head_sha", "commit_time", "workflow_name", "name", "cons_name",
-            "job_id", "run_id", "run_attempt", "started_at", "completed_at",
+            "head_sha",
+            "commit_time",
+            "workflow_name",
+            "name",
+            "cons_name",
+            "job_id",
+            "run_id",
+            "run_attempt",
+            "started_at",
+            "completed_at",
         ]
         unc_rows = [
-            ("sha_obs", T(30), "slow", "linux / test (slow, 2, 3, runner-a)",
-             "linux / test (slow, 2, 3)", 900, 901, 1, T(30), T(40)),
+            (
+                "sha_obs",
+                T(30),
+                "slow",
+                "linux / test (slow, 2, 3, runner-a)",
+                "linux / test (slow, 2, 3)",
+                900,
+                901,
+                1,
+                T(30),
+                T(40),
+            ),
         ]
         base_cols = [
-            "workflow_name", "cons_name", "head_sha", "commit_time", "name",
-            "job_id", "run_id", "run_attempt", "started_at", "completed_at",
+            "workflow_name",
+            "cons_name",
+            "head_sha",
+            "commit_time",
+            "name",
+            "job_id",
+            "run_id",
+            "run_attempt",
+            "started_at",
+            "completed_at",
         ]
         base_rows = [
-            ("slow", "linux / test (slow, 2, 3)", "sha_future", T(50),
-             "linux / test (slow, 2, 3, runner-a)", 700, 701, 1, T(50), T(55)),
-            ("slow", "linux / test (slow, 2, 3)", "sha_before", T(20),
-             "linux / test (slow, 2, 3, runner-a)", 800, 801, 1, T(20), T(25)),
+            (
+                "slow",
+                "linux / test (slow, 2, 3)",
+                "sha_future",
+                T(50),
+                "linux / test (slow, 2, 3, runner-a)",
+                700,
+                701,
+                1,
+                T(50),
+                T(55),
+            ),
+            (
+                "slow",
+                "linux / test (slow, 2, 3)",
+                "sha_before",
+                T(20),
+                "linux / test (slow, 2, 3, runner-a)",
+                800,
+                801,
+                1,
+                T(20),
+                T(25),
+            ),
         ]
         mock_ch = MagicMock()
         mock_ch.return_value.client.query.side_effect = [
@@ -553,8 +615,12 @@ def test_workflow_filter_applied_only_when_set(self):
         enum_wf = UnclassifiedRedEnumerator(make_config(workflows=["slow"]))
         from advisor_coverage.sql import QUERY_UNCLASSIFIED
 
-        self.assertNotIn("workflow_name IN", enum_all._apply_workflow_filter(QUERY_UNCLASSIFIED))
-        self.assertIn("workflow_name IN", enum_wf._apply_workflow_filter(QUERY_UNCLASSIFIED))
+        self.assertNotIn(
+            "workflow_name IN", enum_all._apply_workflow_filter(QUERY_UNCLASSIFIED)
+        )
+        self.assertIn(
+            "workflow_name IN", enum_wf._apply_workflow_filter(QUERY_UNCLASSIFIED)
+        )
 
 
 # ----------------------------------------------------------------------
@@ -639,9 +705,7 @@ def test_cursor_roundtrips_through_parse_datetime(self):
         parsed = CoverageConfig.from_env_and_event(
             {"mode": "backfill", "as_of_start": cursor, "as_of_end": "2026-01-02"}
         )
-        self.assertEqual(
-            parsed.as_of_start.strftime("%Y-%m-%d %H:%M:%S"), cursor
-        )
+        self.assertEqual(parsed.as_of_start.strftime("%Y-%m-%d %H:%M:%S"), cursor)
 
 
 # ----------------------------------------------------------------------

aws/lambda/pytorch-advisor-coverage/advisor_coverage/tests/test_live.py

@@ -59,8 +59,10 @@ def test_enumeration_runs_no_illegal_aggregation(self):
         print(f"\n[live] unclassified reds in last 48h: {len(reds)}")
         if reds:
             total_baselines = sum(len(r.baselines) for r in reds)
-            print(f"[live] sample suspect job_id={reds[0].suspect.job_id} "
-                  f"key={reds[0].job_name!r} baselines_total={total_baselines}")
+            print(
+                f"[live] sample suspect job_id={reds[0].suspect.job_id} "
+                f"key={reds[0].job_name!r} baselines_total={total_baselines}"
+            )
 
 
 @unittest.skipUnless(_LIVE, "needs COVERAGE_LIVE_TESTS=1 (network)")

torchci/clickhouse_queries/flaky_trunk_entity_runs/query.sql

@@ -64,7 +64,10 @@ advisor_agg AS (
             ) AS adv_norm,
             -- Prefer a native (non-coverage_) verdict over a coverage_ one for the same
             -- (commit, job); among equals, the latest timestamp wins.
-            argMax(verdict, (toUInt8(NOT startsWith(signal_key, 'coverage_')), timestamp)) AS verdict
+            argMax(
+                verdict,
+                (toUInt8(NOT startsWith(signal_key, 'coverage_')), timestamp)
+            ) AS verdict
         FROM misc.autorevert_advisor_verdicts
         WHERE
             repo = {repo: String}

torchci/clickhouse_queries/flaky_trunk_jobs/query.sql

@@ -69,7 +69,10 @@ advisor_agg AS (
             ) AS adv_norm,
             -- Prefer a native (non-coverage_) verdict over a coverage_ one for the same
             -- (commit, job); among equals, the latest timestamp wins.
-            argMax(verdict, (toUInt8(NOT startsWith(signal_key, 'coverage_')), timestamp)) AS verdict
+            argMax(
+                verdict,
+                (toUInt8(NOT startsWith(signal_key, 'coverage_')), timestamp)
+            ) AS verdict
         FROM misc.autorevert_advisor_verdicts
         WHERE
             repo = {repo: String}