Commit 63ca335
committed
Normalize PACKAGE_LINKS_ALLOW_LIST to the spelling lookups actually use
Every lookup against this set compares an underscore-spelled name. Package
names come from wheel filenames via obj_to_package_name, and
get_packages_to_copy_from_parent maps parent directory names through
.replace("-", "_") before comparing. But the set stored whatever spelling was
typed, which for most entries is hyphenated -- so "typing_extensions" was
tested against a set holding "typing-extensions" and never matched.
Effect: 77 of the 102 entries could never be copied into an arch subdirectory.
Only single-word names and the four that happened to carry an explicit
underscore twin worked. That is why whl/test/cu134/typing-extensions/ does not
exist and every cu134 smoke test on v2.14.0-rc2 fails to resolve
typing-extensions>=4.10.0 from an index that has no PyPI fallback. cuda-toolkit
was missing from cu134 for the same reason.
Normalize once at definition. The four underscore twins and the comment
explaining that workaround are now redundant, so drop them: 102 entries become
97, and the set they produce grows from 20 reachable names to 97, with no
name that previously worked dropping out.1 parent 82783ad commit 63ca335
1 file changed
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
478 | 478 | | |
479 | 479 | | |
480 | 480 | | |
481 | | - | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
482 | 485 | | |
483 | 486 | | |
484 | 487 | | |
| |||
489 | 492 | | |
490 | 493 | | |
491 | 494 | | |
492 | | - | |
493 | 495 | | |
494 | | - | |
495 | 496 | | |
496 | | - | |
497 | 497 | | |
498 | | - | |
499 | 498 | | |
500 | | - | |
501 | 499 | | |
502 | | - | |
503 | 500 | | |
504 | 501 | | |
505 | 502 | | |
| |||
0 commit comments