Skip to content

Commit 898e177

Browse files
authored
[CRCR] Remove max-retries and retry-delay from cross-repo-ci-relay-callback action (#8145)
Review of the callback lambda logs revealed invalid state transition errors. This issue is caused by redundant `curl` retries within the action that reuse the same `check_run_id` (used as state machine's key). If an initial request successfully transitions the state from `IN_PROGRESS` to `SUCCESS`, a subsequent `IN_PROGRESS` request from a retry is considered invalid because the status is already `COMPLETED`. Since hud.py already includes a retry loop, the curl retries should be removed to prevent these conflicts. cc @zxiiro @atalman @huydhn
1 parent e9d5272 commit 898e177

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

  • .github/actions/cross-repo-ci-relay-callback

.github/actions/cross-repo-ci-relay-callback/action.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,6 @@ inputs:
4646
Maximum time in seconds to wait for the callback HTTP request to complete.
4747
required: false
4848
default: 10
49-
max-retries:
50-
description: >
51-
Maximum number of retries for the callback HTTP request in case of failure.
52-
required: false
53-
default: 3
54-
retry-delay:
55-
description: >
56-
Delay in seconds between retries for the callback HTTP request.
57-
required: false
58-
default: 2
5949

6050
runs:
6151
using: composite
@@ -87,8 +77,6 @@ runs:
8777
RUN_ID: ${{ github.run_id }}
8878
RUN_ATTEMPT: ${{ github.run_attempt }}
8979
MAX_TIME: ${{ inputs.max-time }}
90-
MAX_RETRIES: ${{ inputs.max-retries }}
91-
RETRY_DELAY: ${{ inputs.retry-delay }}
9280
run: |
9381
set -euo pipefail
9482
@@ -158,8 +146,6 @@ runs:
158146
--write-out "%{http_code}" \
159147
-X POST \
160148
--max-time ${MAX_TIME} \
161-
--retry ${MAX_RETRIES} \
162-
--retry-delay ${RETRY_DELAY} \
163149
-H "Content-Type: application/json" \
164150
-H "Authorization: Bearer ${OIDC_TOKEN}" \
165151
--data "${PAYLOAD}" \

0 commit comments

Comments
 (0)