Skip to content

File tree

6 files changed

+308
-129
lines changed

6 files changed

+308
-129
lines changed

torchci/components/benchmark_v3/configs/configurations.tsx

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
} from "components/benchmark_v3/configs/teams/helion/config";
1212
import {
1313
PYTORCH_OPERATOR_MICROBENCHMARK_ID,
14-
PytorchOperatorMicroBenchmarkDashoboardConfig,
14+
PytorchOperatorMicroBenchmarkDashboardConfig,
1515
} from "components/benchmark_v3/configs/teams/torchao/config";
1616
import { BenchmarkCategoryGroup } from "../components/benchmarkList/BenchmarkCategoryCard";
1717
import {
@@ -24,13 +24,17 @@ import {
2424
PytorchGptFastBenchmarkDashboardConfig,
2525
} from "./teams/gptfast/config";
2626
import {
27-
PytorcAoMicroApiBenchmarkDashoboardConfig,
2827
PYTORCH_AO_MICRO_API_BENCHMARK_ID,
28+
PytorchAoMicroApiBenchmarkDashboardConfig,
2929
} from "./teams/torchao/ao_micro_api_config";
3030
import {
31-
PYTORCH_VLLM_BENCHMARK_ID,
32-
PytorchVllmBenchmarkDashoboardConfig,
31+
VLLM_BENCHMARK_ID,
32+
VllmBenchmarkDashboardConfig,
3333
} from "./teams/vllm/config";
34+
import {
35+
PYTORCH_X_VLLM_BENCHMARK_ID,
36+
PytorchXVllmBenchmarkDashboardConfig,
37+
} from "./teams/vllm/pytorch_x_vllm_config";
3438

3539
export const REPORT_ID_TO_BENCHMARK_ID_MAPPING: Record<string, string> = {
3640
compiler_regression: "compiler_inductor",
@@ -40,23 +44,26 @@ export const PREDEFINED_BENCHMARK_CONFIG: BenchmarkConfigMap = {
4044
[COMPILTER_BENCHMARK_NAME]: {
4145
[BenchmarkPageType.DashboardPage]: CompilerDashboardBenchmarkUIConfig,
4246
},
47+
[PYTORCH_X_VLLM_BENCHMARK_ID]: {
48+
[BenchmarkPageType.DashboardPage]: PytorchXVllmBenchmarkDashboardConfig,
49+
},
4350
[COMPILTER_PRECOMPUTE_BENCHMARK_ID]: {
4451
[BenchmarkPageType.AggregatePage]: CompilerPrecomputeBenchmarkUIConfig,
4552
},
4653
[PYTORCH_OPERATOR_MICROBENCHMARK_ID]: {
4754
[BenchmarkPageType.DashboardPage]:
48-
PytorchOperatorMicroBenchmarkDashoboardConfig,
55+
PytorchOperatorMicroBenchmarkDashboardConfig,
4956
},
5057
[PYTORCH_HELION_BENCHMARK_ID]: {
5158
[BenchmarkPageType.DashboardPage]: PytorchHelionDashboardConfig,
5259
[BenchmarkPageType.SinglePage]: PytorchHelionSingleConfig,
5360
},
5461
[PYTORCH_AO_MICRO_API_BENCHMARK_ID]: {
5562
[BenchmarkPageType.DashboardPage]:
56-
PytorcAoMicroApiBenchmarkDashoboardConfig,
63+
PytorchAoMicroApiBenchmarkDashboardConfig,
5764
},
58-
[PYTORCH_VLLM_BENCHMARK_ID]: {
59-
[BenchmarkPageType.DashboardPage]: PytorchVllmBenchmarkDashoboardConfig,
65+
[VLLM_BENCHMARK_ID]: {
66+
[BenchmarkPageType.DashboardPage]: VllmBenchmarkDashboardConfig,
6067
},
6168
[PYTORCH_GPTFAST_BENCHMARK_ID]: {
6269
[BenchmarkPageType.DashboardPage]: PytorchGptFastBenchmarkDashboardConfig,
@@ -69,6 +76,11 @@ export const BENCHMARK_ID_MAPPING: Record<string, BenchmarkIdMappingItem> = {
6976
repoName: "pytorch/pytorch",
7077
benchmarkName: "compiler_inductor",
7178
},
79+
[PYTORCH_X_VLLM_BENCHMARK_ID]: {
80+
id: PYTORCH_X_VLLM_BENCHMARK_ID,
81+
repoName: "pytorch/pytorch",
82+
benchmarkName: "PyTorch x vLLM benchmark",
83+
},
7284
[COMPILTER_PRECOMPUTE_BENCHMARK_ID]: {
7385
id: COMPILTER_PRECOMPUTE_BENCHMARK_ID,
7486
repoName: "pytorch/pytorch",
@@ -89,8 +101,8 @@ export const BENCHMARK_ID_MAPPING: Record<string, BenchmarkIdMappingItem> = {
89101
repoName: "pytorch/ao",
90102
benchmarkName: "micro-benchmark api",
91103
},
92-
[PYTORCH_VLLM_BENCHMARK_ID]: {
93-
id: PYTORCH_VLLM_BENCHMARK_ID,
104+
[VLLM_BENCHMARK_ID]: {
105+
id: VLLM_BENCHMARK_ID,
94106
repoName: "vllm-project/vllm",
95107
benchmarkName: "vLLM benchmark",
96108
},
@@ -151,6 +163,12 @@ export const BENCHMARK_CATEGORIES: BenchmarkCategoryGroup[] = [
151163
},
152164
],
153165
},
166+
{
167+
name: "PyTorch x vLLM Benchmark",
168+
route: `/benchmark/v3/dashboard/${PYTORCH_X_VLLM_BENCHMARK_ID}`,
169+
info: "PyTorch x vLLM nightly benchmark using [vLLM pinned commit](https://github.com/pytorch/pytorch/blob/main/.github/ci_commit_pins/vllm.txt). Powered by [vllm-benchmark workflow](https://github.com/pytorch/pytorch/blob/main/.github/workflows/vllm-benchmark.yml) + [the benchmark configs](https://github.com/pytorch/pytorch-integration-testing/tree/main/vllm-benchmarks/benchmarks)",
170+
description: "Pytorch x vLLM nightly benchmark on PyTorch",
171+
},
154172
{
155173
name: "Gpt-fast Benchmark",
156174
route: `/benchmark/v3/dashboard/${PYTORCH_GPTFAST_BENCHMARK_ID}`,
@@ -207,13 +225,13 @@ export const BENCHMARK_CATEGORIES: BenchmarkCategoryGroup[] = [
207225
],
208226
},
209227
{
210-
title: "vLLM Benchmarks ",
228+
title: "vLLM Benchmarks",
211229
tags: ["repo:vllm-project/vllm"],
212230
subtitle: "Benchmarks related to repo vllm-project/vllm",
213231
items: [
214232
{
215233
name: "VLLM V1 Benchmark",
216-
route: `/benchmark/v3/dashboard/${PYTORCH_VLLM_BENCHMARK_ID}`,
234+
route: `/benchmark/v3/dashboard/${VLLM_BENCHMARK_ID}`,
217235
info: "Powered by [code](https://github.com/pytorch/pytorch-integration-testing/tree/main/vllm-benchmarks/benchmarks)",
218236
actions: [
219237
{

torchci/components/benchmark_v3/configs/teams/torchao/ao_micro_api_config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const COMPARISON_TABLE_METADATA_COLUMNS = [
1919
},
2020
] as const;
2121

22-
export const PytorcAoMicroApiBenchmarkDashoboardConfig: BenchmarkUIConfig = {
22+
export const PytorchAoMicroApiBenchmarkDashboardConfig: BenchmarkUIConfig = {
2323
benchmarkId: PYTORCH_AO_MICRO_API_BENCHMARK_ID,
2424
apiId: PYTORCH_AO_MICRO_API_BENCHMARK_ID,
2525
title: "TorchAo API MicroBenchmark",

torchci/components/benchmark_v3/configs/teams/torchao/config.ts

Lines changed: 110 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -63,131 +63,130 @@ const RENDER_MAPPING_BOOK = {
6363
},
6464
};
6565

66-
export const PytorchOperatorMicroBenchmarkDashoboardConfig: BenchmarkUIConfig =
67-
{
68-
benchmarkId: PYTORCH_OPERATOR_MICROBENCHMARK_ID,
69-
apiId: "pytorch_operator_microbenchmark",
70-
title: "Pytorch Operator MicroBenchmark Dashboard",
71-
type: "dashboard",
72-
dataBinding: {
73-
initial: initialOptions,
74-
required_filter_fields: [],
75-
},
76-
dataRender: {
77-
type: "auto",
78-
sideRender: {
79-
RegressionReportFeature: {
80-
type: "RegressionReportFeature",
81-
title: "Regression Report Section",
82-
config: {
83-
report_id: "pytorch_operator_microbenchmark",
84-
},
66+
export const PytorchOperatorMicroBenchmarkDashboardConfig: BenchmarkUIConfig = {
67+
benchmarkId: PYTORCH_OPERATOR_MICROBENCHMARK_ID,
68+
apiId: "pytorch_operator_microbenchmark",
69+
title: "Pytorch Operator MicroBenchmark Dashboard",
70+
type: "dashboard",
71+
dataBinding: {
72+
initial: initialOptions,
73+
required_filter_fields: [],
74+
},
75+
dataRender: {
76+
type: "auto",
77+
sideRender: {
78+
RegressionReportFeature: {
79+
type: "RegressionReportFeature",
80+
title: "Regression Report Section",
81+
config: {
82+
report_id: "pytorch_operator_microbenchmark",
8583
},
8684
},
87-
subSectionRenders: {
88-
detail_view: {
89-
filterConstraint: {
90-
model: {
91-
disabled: true,
92-
},
93-
deviceName: {
94-
disableOptions: [""],
95-
},
96-
mode: {
97-
disableOptions: [""],
98-
},
85+
},
86+
subSectionRenders: {
87+
detail_view: {
88+
filterConstraint: {
89+
model: {
90+
disabled: true,
9991
},
100-
renders: [
101-
{
102-
type: "AutoBenchmarkTimeSeriesChartGroup",
103-
title: "Metrics Time Series Chart Detail View",
104-
config: {
105-
type: "line",
106-
groupByFields: ["metric"],
107-
lineKey: ["extra_key.use_compile", "dtype", "metric", "branch"],
108-
chart: {
109-
renderOptions: {
110-
chartRenderBook: RENDER_MAPPING_BOOK,
111-
showLegendDetails: true,
112-
},
113-
},
114-
},
115-
},
116-
{
117-
type: "AutoBenchmarkTimeSeriesTable",
118-
title: "Comparison Table Detail View",
119-
config: {
120-
primary: {
121-
fields: ["model"],
122-
displayName: "Model",
123-
},
124-
comparisonPolicy: {
125-
latency: LATENCY_POLICY,
126-
},
127-
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
92+
deviceName: {
93+
disableOptions: [""],
94+
},
95+
mode: {
96+
disableOptions: [""],
97+
},
98+
},
99+
renders: [
100+
{
101+
type: "AutoBenchmarkTimeSeriesChartGroup",
102+
title: "Metrics Time Series Chart Detail View",
103+
config: {
104+
type: "line",
105+
groupByFields: ["metric"],
106+
lineKey: ["extra_key.use_compile", "dtype", "metric", "branch"],
107+
chart: {
128108
renderOptions: {
129-
tableRenderingBook: RENDER_MAPPING_BOOK,
130-
flex: {
131-
primary: 2,
132-
},
109+
chartRenderBook: RENDER_MAPPING_BOOK,
110+
showLegendDetails: true,
133111
},
134112
},
135113
},
136-
{
137-
type: "AutoBenchmarkRawDataTable",
138-
title: "Raw Data Table",
139-
config: {
140-
extraMetadata: [
141-
BRANCH_METADATA_COLUMN,
142-
...COMPARISON_TABLE_METADATA_COLUMNS,
143-
],
144-
renderOptions: {
145-
tableRenderingBook: RENDER_MAPPING_BOOK,
114+
},
115+
{
116+
type: "AutoBenchmarkTimeSeriesTable",
117+
title: "Comparison Table Detail View",
118+
config: {
119+
primary: {
120+
fields: ["model"],
121+
displayName: "Model",
122+
},
123+
comparisonPolicy: {
124+
latency: LATENCY_POLICY,
125+
},
126+
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
127+
renderOptions: {
128+
tableRenderingBook: RENDER_MAPPING_BOOK,
129+
flex: {
130+
primary: 2,
146131
},
147132
},
148133
},
149-
],
150-
},
151-
},
152-
renders: [
153-
{
154-
type: "AutoBenchmarkShortcutCardList",
155-
title: "Operator Lists",
156-
config: {
157-
filters: ["operatorName"],
158134
},
159-
},
160-
{
161-
type: "AutoBenchmarkComparisonGithubExternalLink",
162-
title: "Github runs (external)",
163-
description: "See original github runs for left and right runs",
164-
config: {},
165-
},
166-
{
167-
type: "AutoBenchmarkPairwiseTable",
168-
title: "Comparison Table",
169-
config: {
170-
primary: {
171-
fields: ["model"],
172-
displayName: "Model",
173-
navigation: {
174-
type: "subSectionRender",
175-
value: "detail_view",
176-
applyFilterFields: ["model", "mode", "device", "arch", "dtype"],
135+
{
136+
type: "AutoBenchmarkRawDataTable",
137+
title: "Raw Data Table",
138+
config: {
139+
extraMetadata: [
140+
BRANCH_METADATA_COLUMN,
141+
...COMPARISON_TABLE_METADATA_COLUMNS,
142+
],
143+
renderOptions: {
144+
tableRenderingBook: RENDER_MAPPING_BOOK,
177145
},
178146
},
179-
comparisonPolicy: {
180-
latency: LATENCY_POLICY,
147+
},
148+
],
149+
},
150+
},
151+
renders: [
152+
{
153+
type: "AutoBenchmarkShortcutCardList",
154+
title: "Operator Lists",
155+
config: {
156+
filters: ["operatorName"],
157+
},
158+
},
159+
{
160+
type: "AutoBenchmarkComparisonGithubExternalLink",
161+
title: "Github runs (external)",
162+
description: "See original github runs for left and right runs",
163+
config: {},
164+
},
165+
{
166+
type: "AutoBenchmarkPairwiseTable",
167+
title: "Comparison Table",
168+
config: {
169+
primary: {
170+
fields: ["model"],
171+
displayName: "Model",
172+
navigation: {
173+
type: "subSectionRender",
174+
value: "detail_view",
175+
applyFilterFields: ["model", "mode", "device", "arch", "dtype"],
181176
},
182-
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
183-
renderOptions: {
184-
tableRenderingBook: RENDER_MAPPING_BOOK,
185-
flex: {
186-
primary: 2,
187-
},
177+
},
178+
comparisonPolicy: {
179+
latency: LATENCY_POLICY,
180+
},
181+
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
182+
renderOptions: {
183+
tableRenderingBook: RENDER_MAPPING_BOOK,
184+
flex: {
185+
primary: 2,
188186
},
189187
},
190188
},
191-
],
192-
},
193-
};
189+
},
190+
],
191+
},
192+
};

torchci/components/benchmark_v3/configs/teams/vllm/config.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
DEFAULT_DASHBOARD_BENCHMARK_INITIAL,
55
} from "../defaults/default_dashboard_config";
66

7-
export const PYTORCH_VLLM_BENCHMARK_ID = "vllm_benchmark";
7+
export const VLLM_BENCHMARK_ID = "vllm_benchmark";
88

99
const COMPARISON_TABLE_METADATA_COLUMNS = [
1010
{
@@ -37,15 +37,15 @@ const COMPARISON_TABLE_METADATA_COLUMNS = [
3737
},
3838
] as const;
3939

40-
export const PytorchVllmBenchmarkDashoboardConfig: BenchmarkUIConfig = {
41-
benchmarkId: PYTORCH_VLLM_BENCHMARK_ID,
42-
apiId: PYTORCH_VLLM_BENCHMARK_ID,
40+
export const VllmBenchmarkDashboardConfig: BenchmarkUIConfig = {
41+
benchmarkId: VLLM_BENCHMARK_ID,
42+
apiId: VLLM_BENCHMARK_ID,
4343
title: "VLLM V1 Benchmark",
4444
type: "dashboard",
4545
dataBinding: {
4646
initial: {
4747
...DEFAULT_DASHBOARD_BENCHMARK_INITIAL,
48-
benchmarkId: PYTORCH_VLLM_BENCHMARK_ID,
48+
benchmarkId: VLLM_BENCHMARK_ID,
4949
lbranch: "main(main)",
5050
rbranch: "main(main)",
5151
},

0 commit comments

Comments
 (0)