Skip to content

Commit 8ceeed1

Browse files
authored
[ez][alerts] Increase queue alert threshold to 150 machines (#7024)
Queue alerts fire too frequently, a queue of 75 linux 2x large is not crazy, as long as its a short time. The thresholds need refinement, but I think this is a safe way to reduce the number of alerts. A queue of 150 linux 2x large is probably an issue? maybe
1 parent 7351b79 commit 8ceeed1

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

tools/torchci/queue_alert.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
QUEUE_ALERT_LABEL = "queue-alert"
2121

2222
MAX_HOURS = 4
23-
MAX_MACHINES = 75
23+
MAX_MACHINES = 150
2424
EXCEPTIONS = {"linux.gcp.a100.large": (20, 20)}
2525

2626

tools/torchci/tests/test_queue_alert.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class TestGitHubPR(TestCase):
88
def test_filter_long_queues(self):
99
db_results = [
1010
{"count": 30, "avg_queue_s": 0, "machine_type": "linux.gcp.a100.large"},
11-
{"count": 100, "avg_queue_s": 0, "machine_type": "machine1"},
11+
{"count": 200, "avg_queue_s": 0, "machine_type": "machine1"},
1212
{"count": 30, "avg_queue_s": 3600 * 5, "machine_type": "machine2"},
1313
]
1414
long_queues = filter_long_queues(db_results)

0 commit comments

Comments
 (0)