Commit 8e7041b
authored
HUD: respect Hide non-viable-strict in grouped view (#8116)
## Summary
- When both **Use grouped view** and **Hide non-viable-strict jobs**
were enabled, non-viable-strict failures still lit up grouped columns.
The page-level filter kept any group containing at least one
viable/strict-blocking job, but `HudGroupedCell` aggregated status
across *every* job in the group, so a non-viable-strict failure would
still color the cell red.
- Fix: inside `HudGroupedCell`, when the preference is on, filter the
group's jobs down to viable/strict-blocking ones before computing the
conclusion, autorevert flag, and tooltip contents.
## Test plan
- [x] In HUD with both "Use grouped view" and "Hide non-viable-strict
jobs" enabled, verify groups whose only failing jobs are
non-viable-strict no longer show as failures.
- [x] Confirm tooltips on those grouped cells only list
viable/strict-blocking jobs.
- [x] Toggling off "Hide non-viable-strict jobs" restores prior behavior
(all jobs feed the group status).1 parent 966ee7a commit 8e7041b
1 file changed
Lines changed: 14 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
162 | 173 | | |
163 | 174 | | |
164 | 175 | | |
165 | | - | |
| 176 | + | |
166 | 177 | | |
167 | 178 | | |
168 | 179 | | |
| |||
183 | 194 | | |
184 | 195 | | |
185 | 196 | | |
186 | | - | |
| 197 | + | |
187 | 198 | | |
188 | 199 | | |
189 | 200 | | |
| |||
219 | 230 | | |
220 | 231 | | |
221 | 232 | | |
222 | | - | |
| 233 | + | |
223 | 234 | | |
224 | 235 | | |
225 | 236 | | |
| |||
0 commit comments