[ez] Remove old envs from test times json (#6961)

Please review #6964 first. Not
a functional dependency but it does some file moves that this one
follows too

Reason: test times json super big, and has build environments that don't
exist anymore. Previously I left them in because there might be really
old jobs that depend on the old build environments and I thought the
file would be easy to manually clean up but its just easier to do it
automatically.

Testing: ran script before + after this change and saw that only things
got removed. Spot checked that things that got removed are not on the
front page of HUD

old vs new diff (just shows that the only change is that things got
deleted):
<img width="47" height="944" alt="image"
src="https://github.com/user-attachments/assets/f276ecc5-f656-4020-b25b-9e7ca51d4ecd"
/>

Author: clee2000

tools/torchci/tests/test_update_test_times.py

@@ -1,8 +1,10 @@
 import unittest
+from unittest.mock import patch
 
 from torchci.update_test_times import gen_test_class_times, gen_test_file_times
 
 
+@patch("torchci.update_test_times.clean_up_test_times", lambda x: x)
 class TestUpdateTestTimesFile(unittest.TestCase):
     def make_db_row(self, job: str, config: str, file: str, time: float):
         return {"base_name": job, "test_config": config, "file": file, "time": time}
@@ -98,6 +100,7 @@ def test_gen_test_file_times_old_values_still_present(self) -> None:
         self.assertDictEqual(res, expected)
 
 
+@patch("torchci.update_test_times.clean_up_test_times", lambda x: x)
 class TestUpdateTestTimesClass(unittest.TestCase):
     def make_db_row(
         self, job: str, config: str, file: str, classname: str, time: float
@@ -215,5 +218,35 @@ def test_gen_test_class_times_old_values_still_present(self) -> None:
         self.assertDictEqual(res, expected)
 
 
+class TestCleanUpOldBuildEnvs(unittest.TestCase):
+    def make_db_row(self, job: str, config: str, file: str, time: float):
+        return {"base_name": job, "test_config": config, "file": file, "time": time}
+
+    def test_clean_up_simple(self) -> None:
+        # Simple test to make sure the other build envs are removed
+        data = [
+            self.make_db_row("job1", "config", "a", 1),
+            self.make_db_row("job2", "config", "a", 1),
+            self.make_db_row("job3", "config", "a", 1),
+        ]
+        with patch(
+            "torchci.update_test_times.query_clickhouse_saved",
+            return_value=[{"base_name": "job1"}],
+        ):
+            res = gen_test_file_times(data, {})
+            expected = {
+                "job1": {"config": {"a": 1}},
+                "default": {
+                    "config": {
+                        "a": 1.0,
+                    },
+                    "default": {
+                        "a": 1.0,
+                    },
+                },
+            }
+            self.assertDictEqual(res, expected)
+
+
 if __name__ == "__main__":
     unittest.main()

tools/torchci/update_test_times.py

@@ -12,6 +12,7 @@
 TEST_TIME_PER_FILE_PERIODIC_JOBS_QUERY_NAME = "test_times/per_file_periodic_jobs"
 TEST_TIME_PER_CLASS_QUERY_NAME = "test_times/per_class"
 TEST_TIME_PER_CLASS_PERIODIC_JOBS_QUERY_NAME = "test_times/per_class_periodic_jobs"
+JOB_NAMES_PAST_MONTH_QUERY_NAME = "test_times/job_names_past_month"
 
 
 def get_file_data_from_db():
@@ -77,6 +78,16 @@ def convert_test_class_times_to_default_dict(d):
     return new_d
 
 
+def clean_up_test_times(test_times) -> None:
+    # Remove old environments that no longer run jobs
+    job_names_past_month = query_clickhouse_saved(JOB_NAMES_PAST_MONTH_QUERY_NAME, {})
+    job_names = {row["base_name"] for row in job_names_past_month}
+    job_names.add("default")  # Add default to job names
+    for env in list(test_times.keys()):
+        if env not in job_names:
+            del test_times[env]
+
+
 def gen_test_file_times(db_results, old_test_times):
     # Use old test times because sometimes we want to manually edit the test
     # times json and want those changes to persist.  Unfortunately this means
@@ -108,6 +119,8 @@ def gen_test_file_times(db_results, old_test_times):
         # usually in the default test config like distributed
         test_times["default"]["default"] = test_times_no_test_config
 
+    clean_up_test_times(test_times)
+
     return test_times
 
 
@@ -153,6 +166,8 @@ def gen_test_class_times(db_results, old_test_times):
         # usually in the default test config like distributed
         test_times["default"]["default"] = test_times_no_test_config
 
+    clean_up_test_times(test_times)
+
     return test_times
 
 

torchci/clickhouse_queries/test_times/job_names_past_month/params.json

@@ -0,0 +1,4 @@
+{
+  "params": {},
+  "tests": [{}]
+}

torchci/clickhouse_queries/test_times/job_names_past_month/query.sql

@@ -0,0 +1,4 @@
+SELECT DISTINCT REGEXP_EXTRACT(j.name, '^(.*) /', 1) AS base_name
+FROM
+    default.workflow_job j
+WHERE j.created_at > now() - INTERVAL 1 MONTH