[PyTorchBot] Remove irrelevant labels (#7463)

- `release notes:`/`topic:`/`ciflow/` should only be added to PR
- `module:`/`oncall:` should only be added to labels

Make bot do that and add tests (coded by Claude)

Author: malfet

torchci/lib/bot/autoLabelBot.ts

@@ -429,6 +429,28 @@ function myBot(app: Probot): void {
 
     const filtered = await filterCIFlowLabels(true, newLabels);
     await addNewLabels(existingLabels, filtered, context);
+
+    // Remove PR-only labels from issues
+    if (
+      addedLabel.startsWith("release notes:") ||
+      addedLabel.startsWith("ciflow/")
+    ) {
+      context.log(
+        `Removing PR-only label "${addedLabel}" from issue ${context.payload.issue.html_url}`
+      );
+      await context.octokit.issues.removeLabel(
+        context.repo({
+          issue_number: context.payload.issue.number,
+          name: addedLabel,
+        })
+      );
+      await context.octokit.issues.createComment(
+        context.repo({
+          issue_number: context.payload.issue.number,
+          body: `The label \`${addedLabel}\` is only applicable to pull requests and has been removed. Please only use this label on PRs.`,
+        })
+      );
+    }
   });
 
   app.on(["issues.opened", "issues.edited"], async (context) => {
@@ -542,6 +564,36 @@ function myBot(app: Probot): void {
     }
     await addNewLabels(existingLabels, labelsToAdd, context);
   });
+
+  app.on("pull_request.labeled", async (context) => {
+    const owner = context.payload.repository.owner.login;
+    if (!isPyTorchbotSupportedOrg(owner)) {
+      context.log(`${__filename} isn't enabled on ${owner}'s repos`);
+      return;
+    }
+
+    const addedLabel = context.payload.label!.name;
+    context.log({ addedLabel });
+
+    // Remove issue-only labels from PRs
+    if (addedLabel.startsWith("module:") || addedLabel.startsWith("oncall:")) {
+      context.log(
+        `Removing issue-only label "${addedLabel}" from PR ${context.payload.pull_request.html_url}`
+      );
+      await context.octokit.issues.removeLabel(
+        context.repo({
+          issue_number: context.payload.pull_request.number,
+          name: addedLabel,
+        })
+      );
+      await context.octokit.issues.createComment(
+        context.repo({
+          issue_number: context.payload.pull_request.number,
+          body: `The label \`${addedLabel}\` is only applicable to issues and has been removed. Please only use this label on issues.`,
+        })
+      );
+    }
+  });
 }
 
 export default myBot;

torchci/test/autoLabelBot.test.ts

@@ -1278,3 +1278,140 @@ adfadsfasd
     await probot.receive(event);
   });
 });
+
+describe("auto-label-bot: label restrictions", () => {
+  let probot: Probot;
+
+  function emptyMockConfig(repoFullName: string) {
+    utils.mockConfig("pytorch-probot.yml", "", repoFullName);
+  }
+
+  beforeEach(() => {
+    probot = utils.testProbot();
+    probot.load(myProbotApp);
+    const mock = jest.spyOn(botUtils, "isPyTorchPyTorch");
+    mock.mockReturnValue(true);
+    const mockbotSupportedOrg = jest.spyOn(
+      botUtils,
+      "isPyTorchbotSupportedOrg"
+    );
+    mockbotSupportedOrg.mockReturnValue(true);
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+    nock.cleanAll();
+  });
+
+  test("remove release notes label from issue", async () => {
+    nock("https://api.github.com")
+      .post("/app/installations/2/access_tokens")
+      .reply(200, { token: "test" });
+
+    const payload = requireDeepCopy("./fixtures/issues.labeled");
+    payload["label"] = { name: "release notes: nn" };
+    payload["issue"]["labels"] = [{ name: "release notes: nn" }];
+    emptyMockConfig(payload.repository.full_name);
+
+    const scope = nock("https://api.github.com")
+      .delete(
+        "/repos/ezyang/testing-ideal-computing-machine/issues/5/labels/release%20notes%3A%20nn"
+      )
+      .reply(200)
+      .post(
+        "/repos/ezyang/testing-ideal-computing-machine/issues/5/comments",
+        (body) => {
+          expect(body.body).toContain("release notes: nn");
+          expect(body.body).toContain("only applicable to pull requests");
+          return true;
+        }
+      )
+      .reply(200);
+
+    await probot.receive({ name: "issues", payload, id: "2" });
+
+    handleScope(scope);
+  });
+
+  test("remove ciflow label from issue", async () => {
+    nock("https://api.github.com")
+      .post("/app/installations/2/access_tokens")
+      .reply(200, { token: "test" });
+
+    const payload = requireDeepCopy("./fixtures/issues.labeled");
+    payload["label"] = { name: "ciflow/rocm" };
+    payload["issue"]["labels"] = [{ name: "ciflow/rocm" }];
+    emptyMockConfig(payload.repository.full_name);
+
+    const scope = nock("https://api.github.com")
+      .delete(
+        "/repos/ezyang/testing-ideal-computing-machine/issues/5/labels/ciflow%2Frocm"
+      )
+      .reply(200)
+      .post(
+        "/repos/ezyang/testing-ideal-computing-machine/issues/5/comments",
+        (body) => {
+          expect(body.body).toContain("ciflow/rocm");
+          expect(body.body).toContain("only applicable to pull requests");
+          return true;
+        }
+      )
+      .reply(200);
+
+    await probot.receive({ name: "issues", payload, id: "2" });
+
+    handleScope(scope);
+  });
+
+  test("remove module label from pull request", async () => {
+    nock("https://api.github.com")
+      .post("/app/installations/2/access_tokens")
+      .reply(200, { token: "test" });
+
+    const payload = requireDeepCopy("./fixtures/pull_request.labeled");
+    payload["label"] = { name: "module: ci" };
+    payload["pull_request"]["labels"] = [{ name: "module: ci" }];
+    emptyMockConfig(payload.repository.full_name);
+
+    const scope = nock("https://api.github.com")
+      .delete("/repos/seemethere/test-repo/issues/20/labels/module%3A%20ci")
+      .reply(200)
+      .post("/repos/seemethere/test-repo/issues/20/comments", (body) => {
+        expect(body.body).toContain("module: ci");
+        expect(body.body).toContain("only applicable to issues");
+        return true;
+      })
+      .reply(200);
+
+    await probot.receive({ name: "pull_request", payload, id: "2" });
+
+    handleScope(scope);
+  });
+
+  test("remove oncall label from pull request", async () => {
+    nock("https://api.github.com")
+      .post("/app/installations/2/access_tokens")
+      .reply(200, { token: "test" });
+
+    const payload = requireDeepCopy("./fixtures/pull_request.labeled");
+    payload["label"] = { name: "oncall: distributed" };
+    payload["pull_request"]["labels"] = [{ name: "oncall: distributed" }];
+    emptyMockConfig(payload.repository.full_name);
+
+    const scope = nock("https://api.github.com")
+      .delete(
+        "/repos/seemethere/test-repo/issues/20/labels/oncall%3A%20distributed"
+      )
+      .reply(200)
+      .post("/repos/seemethere/test-repo/issues/20/comments", (body) => {
+        expect(body.body).toContain("oncall: distributed");
+        expect(body.body).toContain("only applicable to issues");
+        return true;
+      })
+      .reply(200);
+
+    await probot.receive({ name: "pull_request", payload, id: "2" });
+
+    handleScope(scope);
+  });
+});