Skip to content

Commit a0685f6

Browse files
authored
Add docs-build to viable-strict blocking workflows in HUD (#8187)
## Summary Adds the `docs-build` workflow to the viable-strict blocking set that HUD recognizes, across both the frontend classifier/metrics and the ClickHouse/Grafana queries. ## Why `docs-build` is being added to the auto-revert bot's viable-strict blocking group (pytorch-gha-infra), so HUD needs to treat it as viable/strict blocking too — otherwise its failures wouldn't show in the viable-strict views, red-commit metrics, or the broken-viable-strict alert, leaving the two systems inconsistent. The classifier comment points to `update-viablestrict.yml` in pytorch/pytorch as the source of truth — `docs-build` must also be added there for these mirrors to be correct. --------- Signed-off-by: Huy Do <huydo@meta.com>
1 parent 74f153b commit a0685f6

5 files changed

Lines changed: 13 additions & 6 deletions

File tree

clickhouse_db_schema/grafana_alerts/broken_viable_strict.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ WITH raw_jobs AS (
2323
WHERE
2424
-- Filter down to the viable/strict blocking jobs we care about
2525
(
26-
j.workflow_name IN ('pull', 'trunk')
26+
j.workflow_name IN ('pull', 'trunk', 'docs-build')
2727
OR j.workflow_name LIKE 'linux-binary-%'
2828
)
2929
AND j.job_name NOT LIKE '%rerun_disabled_tests%'

torchci/clickhouse_queries/master_commit_red/query.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ all_runs AS (
3333
'Lint',
3434
'pull',
3535
'trunk',
36-
'linux-aarch64'
36+
'linux-aarch64',
37+
'docs-build'
3738
)
3839
AND workflow_run.event != 'workflow_run' -- Filter out workflow_run-triggered jobs, which have nothing to do with the SHA
3940
AND workflow_run.id IN (

torchci/lib/JobClassifierUtil.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,13 @@ type RepoViableStrictBlockingJobsMap = {
99

1010
// Source of truth for these jobs is in https://github.com/pytorch/pytorch/blob/main/.github/workflows/update-viablestrict.yml#L26
1111
export const VIABLE_STRICT_BLOCKING_JOBS: RepoViableStrictBlockingJobsMap = {
12-
"pytorch/pytorch": [/pull/i, /trunk/i, /lint/i, /linux-aarch64/i],
12+
"pytorch/pytorch": [
13+
/pull/i,
14+
/trunk/i,
15+
/lint/i,
16+
/linux-aarch64/i,
17+
/docs-build/i,
18+
],
1319
};
1420

1521
export function isJobViableStrictBlocking(

torchci/pages/kpis.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default function Kpis() {
2424
queryParams={{
2525
...timeParams,
2626
granularity: "week",
27-
workflowNames: ["lint", "pull", "trunk"],
27+
workflowNames: ["lint", "pull", "trunk", "docs-build"],
2828
}}
2929
granularity={"week"}
3030
timeFieldName={"granularity_bucket"}

torchci/pages/metrics.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ export default function Page() {
496496
JSON.stringify({
497497
...timeParams,
498498
// TODO (huydhn): Figure out a way to have default parameters for ClickHouse queries
499-
workflowNames: ["lint", "pull", "trunk", "linux-aarch64"],
499+
workflowNames: ["lint", "pull", "trunk", "linux-aarch64", "docs-build"],
500500
})
501501
)}`;
502502

@@ -841,7 +841,7 @@ export default function Page() {
841841
<WorkflowDuration
842842
percentile={ttsPercentile}
843843
timeParams={timeParams}
844-
workflowNames={["pull", "trunk"]}
844+
workflowNames={["pull", "trunk", "docs-build"]}
845845
/>
846846
</Stack>
847847
</Grid>

0 commit comments

Comments
 (0)