Correctly return 200 in api/flaky-tests/disable (#6184)

huydhn · Camyll · commit b972178769a6 · 2025-01-21T13:31:35.000-08:00
When investigating pytorch/pytorch#144964, I notice that `api/flaky-tests/disable` returns 403 error code even when I use the correct credential. Same goes on https://vercel.com/fbopensource/torchci/logs?requestPaths=%2Fapi%2Fflaky-tests%2Fdisable&selectedLogId=cv6z2-1736966788286-ab32c5324f42&timeline=maximum&page=2
diff --git a/torchci/pages/api/flaky-tests/disable.ts b/torchci/pages/api/flaky-tests/disable.ts
@@ -29,8 +29,9 @@ export default async function handler(
   if (authorization === process.env.FLAKY_TEST_BOT_KEY) {
     await disableFlakyTestsAndReenableNonFlakyTests();
     res.status(200).end();
+  } else {
+    res.status(403).end();
   }
-  res.status(403).end();
 }
 
 async function disableFlakyTestsAndReenableNonFlakyTests() {

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,9 @@ export default async function handler(`
`29`	`29`	`if (authorization === process.env.FLAKY_TEST_BOT_KEY) {`
`30`	`30`	`await disableFlakyTestsAndReenableNonFlakyTests();`
`31`	`31`	`res.status(200).end();`
	`32`	`+ } else {`
	`33`	`+ res.status(403).end();`
`32`	`34`	`}`
`33`		`- res.status(403).end();`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`async function disableFlakyTestsAndReenableNonFlakyTests() {`